github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-07-16 04:48:50 -05:00
Code Issues 2.9k Packages Projects Releases Wiki Activity

[PR #937] [MERGED] fix: keep Valkey internal #16249

New Issue
Closed
opened 2026-07-14 23:16:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-14 23:16:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/937
Author: @rohitmulani63-ops
Created: 6/22/2026
Status: ✅ Merged
Merged: 7/7/2026
Merged by: @Siumauricio

Base: canary ← Head: codex/fix-valkey-port-exposure

📝 Commits (1)

  • 31bfe98 fix: keep Valkey internal

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 blueprints/valkey/docker-compose.yml (+0 -2)

📄 Description

Summary

Closes #684.

Removes the bare ports: mapping from the Valkey template so Dokploy does not publish Valkey externally on a random host port.

Valkey still listens on port 6379 inside the compose network, but it is no longer exposed to the host. That matches the expected isolated deployment behavior for an internal database/cache service.

Validation

  • npm.cmd run validate-template -- --dir ../blueprints/valkey
  • npm.cmd run validate-docker-compose -- --file ../blueprints/valkey/docker-compose.yml
  • git diff --check

The template validator warns that Valkey has no configured domains, which is expected for this non-web service.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/937 **Author:** [@rohitmulani63-ops](https://github.com/rohitmulani63-ops) **Created:** 6/22/2026 **Status:** ✅ Merged **Merged:** 7/7/2026 **Merged by:** [@Siumauricio](https://github.com/Siumauricio) **Base:** `canary` ← **Head:** `codex/fix-valkey-port-exposure` --- ### 📝 Commits (1) - [`31bfe98`](https://github.com/Dokploy/templates/commit/31bfe9873f3526486f1b91e5da4942e1205100a9) fix: keep Valkey internal ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/valkey/docker-compose.yml` (+0 -2) </details> ### 📄 Description ## Summary Closes #684. Removes the bare `ports:` mapping from the Valkey template so Dokploy does not publish Valkey externally on a random host port. Valkey still listens on port 6379 inside the compose network, but it is no longer exposed to the host. That matches the expected isolated deployment behavior for an internal database/cache service. ## Validation - `npm.cmd run validate-template -- --dir ../blueprints/valkey` - `npm.cmd run validate-docker-compose -- --file ../blueprints/valkey/docker-compose.yml` - `git diff --check` The template validator warns that Valkey has no configured domains, which is expected for this non-web service. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-14 23:16:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#16249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?