[PR #665] Added the frappe lending template #14112

Closed
opened 2026-06-17 06:17:57 -05:00 by GiteaMirror · 0 comments
Owner

Original Pull Request: https://github.com/Dokploy/templates/pull/665

State: closed
Merged: Yes


Description

Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Technical Details

  • Base Image: frappe/erpnext:v15
  • Apps: ERPNext + Lending
  • Services: Backend, Frontend (Nginx), MariaDB, Redis, Queue Workers
  • Port: 8080
Screenshot 2026-01-13 at 5 55 37 PM

Greptile Summary

Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations.

Key changes:

  • New blueprint directory with docker-compose.yml, template.toml, and logo
  • Configured services: backend, frontend (Nginx), MariaDB, Redis, queue workers (default, long, short), scheduler, websocket
  • Added configurator and create-site services for initial setup
  • Configured lending app installation and site creation logic
  • Added entry to meta.json with appropriate tags

Issues identified:

  • Missing version: "3.8" field at the start of docker-compose.yml (required by style guide)
  • Using VERSION=latest in template.toml and meta.json instead of pinning to specific version like v15

Positive aspects:

  • Correctly avoids using networks (unlike other frappe templates in the repo)
  • Correctly avoids using ports and container_name directives
  • Proper use of volumes for data persistence
  • Comprehensive healthchecks and service dependencies

Confidence Score: 4/5

  • This PR is safe to merge with minor fixes needed
  • The template follows most Dokploy conventions and adds a functional Frappe Lending deployment. The issues found are primarily style-related (missing version field, using latest instead of pinned version). The template correctly avoids problematic directives like networks, ports, and container_name. Once the version field is added and versions are pinned, this will be fully compliant.
  • docker-compose.yml needs version field added, template.toml and meta.json need version pinning from latest to v15

Last reviewed commit: 9c637bb

Context used:

  • Context from dashboard - AGENTS.md (source)
**Original Pull Request:** https://github.com/Dokploy/templates/pull/665 **State:** closed **Merged:** Yes --- ## Description Adds Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations. ## Technical Details - **Base Image**: `frappe/erpnext:v15` - **Apps**: ERPNext + Lending - **Services**: Backend, Frontend (Nginx), MariaDB, Redis, Queue Workers - **Port**: 8080 <img width="1416" height="854" alt="Screenshot 2026-01-13 at 5 55 37 PM" src="https://github.com/user-attachments/assets/cc77c5ea-adbd-47e6-b479-5e55c725fe31" /> <!-- greptile_comment --> <h3>Greptile Summary</h3> Added Frappe Lending template - a loan management system built on Frappe Framework for managing loans, repayments, and lending operations. **Key changes:** - New blueprint directory with docker-compose.yml, template.toml, and logo - Configured services: backend, frontend (Nginx), MariaDB, Redis, queue workers (default, long, short), scheduler, websocket - Added configurator and create-site services for initial setup - Configured lending app installation and site creation logic - Added entry to meta.json with appropriate tags **Issues identified:** - Missing `version: "3.8"` field at the start of docker-compose.yml (required by style guide) - Using `VERSION=latest` in template.toml and meta.json instead of pinning to specific version like `v15` **Positive aspects:** - Correctly avoids using `networks` (unlike other frappe templates in the repo) - Correctly avoids using `ports` and `container_name` directives - Proper use of volumes for data persistence - Comprehensive healthchecks and service dependencies <h3>Confidence Score: 4/5</h3> - This PR is safe to merge with minor fixes needed - The template follows most Dokploy conventions and adds a functional Frappe Lending deployment. The issues found are primarily style-related (missing version field, using latest instead of pinned version). The template correctly avoids problematic directives like networks, ports, and container_name. Once the version field is added and versions are pinned, this will be fully compliant. - docker-compose.yml needs version field added, template.toml and meta.json need version pinning from latest to v15 <sub>Last reviewed commit: 9c637bb</sub> <!-- greptile_other_comments_section --> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment -->
GiteaMirror added the pull-request label 2026-06-17 06:17:57 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#14112