[PR #782] feat: add Shopware blueprint #1309

New Issue

GiteaMirror · 2026-04-16T11:33:45-05:00

GiteaMirror commented

2026-04-16 11:33:45 -05:00

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/782
Author: @zrja
Created: 4/9/2026
Status: 🔄 Open

Base: canary ← Head: zrja/shopware-v1

📝 Commits (4)

ac5f9b9 feat: add shopware blueprint
3100430 fix: address shopware review feedback
d0821bd fix: remove duplicate strapi entry
fed39e3 fix: address remaining shopware review notes

📊 Changes

4 files changed (+449 additions, -18 deletions)

View changed files

➕ blueprints/shopware/docker-compose.yml (+328 -0)
➕ blueprints/shopware/logo.svg (+24 -0)
➕ blueprints/shopware/template.toml (+78 -0)
📝 meta.json (+19 -18)

📄 Description

What is this PR about?

New PR of Shopware

This PR:

adds a new shopware blueprint with docker-compose.yml, template.toml, and logo.svg
adds the shopware entry to meta.json
runs node dedupe-and-sort-meta.js
addresses review feedback by pinning image tags and renaming the primary service to shopware

Checklist

Before submitting this PR, please make sure that:

I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template
I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong.
I have added tests that demonstrate that my correction works or that my new feature works.

None.

Screenshots or Videos

Not included.

Greptile Summary

This PR adds a complete Shopware 6 blueprint with a multi-stage init chain (bootstrap → init-permissions → init → runtime services), MySQL 8.4, Redis 7.4, a background worker, and a scheduler. All repo conventions are met: version 3.8, named volumes only, expose instead of ports, and the primary service is named shopware to match the blueprint folder.

The only finding is a minor inconsistency in the init, shopware, worker, and scheduler entrypoints, which use a bare $ for shell command substitutions ($(cat ...)) while bootstrap correctly uses $$ to escape the $ from Docker Compose's variable interpolation engine. In practice this works on current Docker Compose v2, but the $$ form is the guaranteed-safe approach.

Confidence Score: 5/5

Safe to merge — the only finding is a cosmetic $ vs $$ inconsistency that works correctly on all current Docker Compose v2 releases.
All remaining findings are P2 style suggestions. The blueprint is functional, tested by the author, follows all repo conventions, and prior review feedback on restart policies and failed-queue documentation has been fully addressed.
No files require special attention.

_{Reviews (2): Last reviewed commit: "fix: address remaining shopware review n..." | Re-trigger Greptile}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/782 **Author:** [@zrja](https://github.com/zrja) **Created:** 4/9/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `zrja/shopware-v1` --- ### 📝 Commits (4) - [`ac5f9b9`](https://github.com/Dokploy/templates/commit/ac5f9b995a379e56d5ac3fc684ebc86fcaa91e3e) feat: add shopware blueprint - [`3100430`](https://github.com/Dokploy/templates/commit/3100430dc56e8a17d91c561fa0cadae728284ce5) fix: address shopware review feedback - [`d0821bd`](https://github.com/Dokploy/templates/commit/d0821bdb39cf8c2572f00d316b9793e475eb5408) fix: remove duplicate strapi entry - [`fed39e3`](https://github.com/Dokploy/templates/commit/fed39e395e00f80b0253dc6f9ace384cad1ed119) fix: address remaining shopware review notes ### 📊 Changes **4 files changed** (+449 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/shopware/docker-compose.yml` (+328 -0) ➕ `blueprints/shopware/logo.svg` (+24 -0) ➕ `blueprints/shopware/template.toml` (+78 -0) 📝 `meta.json` (+19 -18) </details> ### 📄 Description ## What is this PR about? New PR of Shopware This PR: - adds a new `shopware` blueprint with `docker-compose.yml`, `template.toml`, and `logo.svg` - adds the `shopware` entry to `meta.json` - runs `node dedupe-and-sort-meta.js` - addresses review feedback by pinning image tags and renaming the primary service to `shopware` ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) None. ## Screenshots or Videos Not included.  <h3>Greptile Summary</h3> This PR adds a complete Shopware 6 blueprint with a multi-stage init chain (bootstrap → init-permissions → init → runtime services), MySQL 8.4, Redis 7.4, a background worker, and a scheduler. All repo conventions are met: version `3.8`, named volumes only, `expose` instead of `ports`, and the primary service is named `shopware` to match the blueprint folder. The only finding is a minor inconsistency in the `init`, `shopware`, `worker`, and `scheduler` entrypoints, which use a bare `$` for shell command substitutions (`$(cat ...)`) while `bootstrap` correctly uses `$$` to escape the `$` from Docker Compose's variable interpolation engine. In practice this works on current Docker Compose v2, but the `$$` form is the guaranteed-safe approach. <h3>Confidence Score: 5/5</h3> - Safe to merge — the only finding is a cosmetic `$` vs `$$` inconsistency that works correctly on all current Docker Compose v2 releases. - All remaining findings are P2 style suggestions. The blueprint is functional, tested by the author, follows all repo conventions, and prior review feedback on restart policies and failed-queue documentation has been fully addressed. - No files require special attention. <sub>Reviews (2): Last reviewed commit: ["fix: address remaining shopware review n..."](https://github.com/dokploy/templates/commit/fed39e395e00f80b0253dc6f9ace384cad1ed119) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=27807934)</sub>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-16 11:33:45 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/templates#1309