github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-07 17:18:26 -05:00
Code Issues 1.2k Packages Projects Releases Wiki Activity

[PR #774] [CLOSED] Update ERPNext version, database image, and site configuration #1302

New Issue
Closed
opened 2026-04-16 11:33:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 11:33:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/774
Author: @satyatulasijalandharch
Created: 4/7/2026
Status: ❌ Closed

Base: canary ← Head: erpnext-template-update-to-v16

📝 Commits (10+)

  • 68fc6b0 feat: update ERPNext version to 16 in docker-compose and template files
  • 1559a40 fix: update ping API URL in entrypoint command for site maintenance
  • 87a8572 feat: update database image to mariadb 11.8 in docker-compose and template files
  • 12b052f feat: add site volume configuration options to ERPNext template
  • d4ade41 fix: update ping API URL to use HTTPS in entrypoint command
  • 6827034 feat: update ERPNext version to 16 in meta.json
  • 5efc639 fix: update ping API command to use service URL in entrypoint script
  • 568fdf2 fix: clear site volume configuration options in ERPNext template
  • 4049f9d fix: update website link to Frappe in meta.json
  • 2c494f7 refactor: restructure environment variables and mounts in template.toml

📊 Changes

3 files changed (+86 additions, -142 deletions)

View changed files

📝 blueprints/erpnext/docker-compose.yml (+64 -105)
📝 blueprints/erpnext/template.toml (+19 -17)
📝 meta.json (+3 -20)

📄 Description

This pull request updates the ERPNext deployment configuration to use newer versions of ERPNext and MariaDB, and introduces additional environment variables for site volume configuration. The most important changes are grouped below:

Version Upgrades:

  • Updated the ERPNext Docker image to use version-16 instead of version-15 in both docker-compose.yml and template.toml. [1] [2]
  • Changed the MariaDB image to use version 11.8 (with the option to override via the DB_IMAGE environment variable) instead of the hardcoded mariadb:10.6. [1] [2]

Configuration Improvements:

  • Changed the health check endpoint to use internal host frontend for improved security when pinging the site.
  • Added new environment variables for site volume configuration: SITE_VOLUME_TYPE, SITE_VOLUME_OPTS, and SITE_VOLUME_DEV.

Checklist

Before submitting this PR, please make sure that:

Greptile Summary

This PR upgrades ERPNext to version-16, makes the MariaDB image overridable via DB_IMAGE (defaulting to mariadb:11.8), and introduces site volume configuration env vars. Two P1 issues need attention before merging:

  • The migration health check now uses HTTPS; due to shell operator precedence, exit 0 is always reached and the actual bench migrate commands are silently skipped.
  • SITE_VOLUME_DEV=/${main_domain}/sites points to an unusual host path (e.g. /example.com/sites) that won't exist or be created automatically, causing all services to fail on a fresh deployment.

Confidence Score: 4/5

Not safe to merge as-is; two P1 defects can silently skip database migrations and break all services on fresh deployments.

The bind mount path issue and the HTTPS health check / shell logic bug are both present defects on the primary deployment path.

blueprints/erpnext/docker-compose.yml (migration health check shell logic, sites volume missing driver) and blueprints/erpnext/template.toml (SITE_VOLUME_DEV path)

Reviews (1): Last reviewed commit: "fix: update ping API URL to use HTTPS in..." | Re-trigger Greptile

Greptile also left 2 inline comments on this PR.

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/774 **Author:** [@satyatulasijalandharch](https://github.com/satyatulasijalandharch) **Created:** 4/7/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `erpnext-template-update-to-v16` --- ### 📝 Commits (10+) - [`68fc6b0`](https://github.com/Dokploy/templates/commit/68fc6b09d7295818082f4b5cfb8c5f5a0b46fe56) feat: update ERPNext version to 16 in docker-compose and template files - [`1559a40`](https://github.com/Dokploy/templates/commit/1559a4017c5a08094230af3bad026dd7d97ffbda) fix: update ping API URL in entrypoint command for site maintenance - [`87a8572`](https://github.com/Dokploy/templates/commit/87a857225ab23fd9490bb0a5453b371d42716fc2) feat: update database image to mariadb 11.8 in docker-compose and template files - [`12b052f`](https://github.com/Dokploy/templates/commit/12b052fc7631aa47fe29d5dc671c5a1ac8144cfd) feat: add site volume configuration options to ERPNext template - [`d4ade41`](https://github.com/Dokploy/templates/commit/d4ade41371b6c5326e73fbca84ef0df0c31e9c8c) fix: update ping API URL to use HTTPS in entrypoint command - [`6827034`](https://github.com/Dokploy/templates/commit/68270348c0bd1610f05e54a453b957747870c715) feat: update ERPNext version to 16 in meta.json - [`5efc639`](https://github.com/Dokploy/templates/commit/5efc639668c25b449238ad93555cbff19255bc91) fix: update ping API command to use service URL in entrypoint script - [`568fdf2`](https://github.com/Dokploy/templates/commit/568fdf217359a32356ebd71391f2a3b798cdfdf0) fix: clear site volume configuration options in ERPNext template - [`4049f9d`](https://github.com/Dokploy/templates/commit/4049f9dfea1a5e5ddca4217c6e87d2a1922e3cfa) fix: update website link to Frappe in meta.json - [`2c494f7`](https://github.com/Dokploy/templates/commit/2c494f71d680fd741a7f15766482bc5e7b1cfd2f) refactor: restructure environment variables and mounts in template.toml ### 📊 Changes **3 files changed** (+86 additions, -142 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/erpnext/docker-compose.yml` (+64 -105) 📝 `blueprints/erpnext/template.toml` (+19 -17) 📝 `meta.json` (+3 -20) </details> ### 📄 Description This pull request updates the ERPNext deployment configuration to use newer versions of ERPNext and MariaDB, and introduces additional environment variables for site volume configuration. The most important changes are grouped below: **Version Upgrades:** * Updated the ERPNext Docker image to use `version-16` instead of `version-15` in both `docker-compose.yml` and `template.toml`. [[1]](diffhunk://#diff-6d871580d80ebbef4f91229fcd87aea88211a34b22c23639b1c8ebe9f06d75e3L2-R2) [[2]](diffhunk://#diff-4c7b91da0e09bf001e385385e7e915c7707a90263356a7aaf02e6ba23dbb81a3L19-R24) * Changed the MariaDB image to use version `11.8` (with the option to override via the `DB_IMAGE` environment variable) instead of the hardcoded `mariadb:10.6`. [[1]](diffhunk://#diff-6d871580d80ebbef4f91229fcd87aea88211a34b22c23639b1c8ebe9f06d75e3L265-R265) [[2]](diffhunk://#diff-4c7b91da0e09bf001e385385e7e915c7707a90263356a7aaf02e6ba23dbb81a3L19-R24) **Configuration Improvements:** * Changed the health check endpoint to use internal host `frontend` for improved security when pinging the site. * Added new environment variables for site volume configuration: `SITE_VOLUME_TYPE`, `SITE_VOLUME_OPTS`, and `SITE_VOLUME_DEV`. ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR upgrades ERPNext to `version-16`, makes the MariaDB image overridable via `DB_IMAGE` (defaulting to `mariadb:11.8`), and introduces site volume configuration env vars. Two P1 issues need attention before merging: - The migration health check now uses HTTPS; due to shell operator precedence, `exit 0` is always reached and the actual `bench migrate` commands are silently skipped. - `SITE_VOLUME_DEV=/${main_domain}/sites` points to an unusual host path (e.g. `/example.com/sites`) that won't exist or be created automatically, causing all services to fail on a fresh deployment. <h3>Confidence Score: 4/5</h3> Not safe to merge as-is; two P1 defects can silently skip database migrations and break all services on fresh deployments. The bind mount path issue and the HTTPS health check / shell logic bug are both present defects on the primary deployment path. blueprints/erpnext/docker-compose.yml (migration health check shell logic, sites volume missing driver) and blueprints/erpnext/template.toml (SITE_VOLUME_DEV path) <sub>Reviews (1): Last reviewed commit: ["fix: update ping API URL to use HTTPS in..."](https://github.com/dokploy/templates/commit/d4ade41371b6c5326e73fbca84ef0df0c31e9c8c) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=27548073)</sub> > Greptile also left **2 inline comments** on this PR. <sub>(2/5) Greptile learns from your feedback when you react with thumbs up/down!</sub> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 11:33:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#1302
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?