github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-05-06 16:55:42 -05:00
Code Issues 1.1k Packages Projects Releases Wiki Activity

[PR #759] feat: add crawlab #1289

New Issue
Open
opened 2026-04-16 11:33:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 11:33:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/759
Author: @spacewaterbear
Created: 3/28/2026
Status: 🔄 Open

Base: canary ← Head: crawlab

📝 Commits (4)

  • 57c094d feat: add crawlab
  • bfd8fa3 feat: add crawlab - re order
  • f24ccf6 feat: add crawlab - fix compose
  • a9c5b30 feat: split crawlab into worker and master

📊 Changes

7 files changed (+116 additions, -18 deletions)

View changed files

➕ blueprints/crawlab-master/crawlab.jpeg (+0 -0)
➕ blueprints/crawlab-master/docker-compose.yml (+41 -0)
➕ blueprints/crawlab-master/template.toml (+12 -0)
➕ blueprints/crawlab-worker/crawlab.jpeg (+0 -0)
➕ blueprints/crawlab-worker/docker-compose.yml (+20 -0)
➕ blueprints/crawlab-worker/template.toml (+7 -0)
📝 meta.json (+36 -18)

📄 Description

What is this PR about?

New PR of Crawlab (crawler management plateform)

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Close automatically the related issues using the keywords: closes #ISSUE_NUMBER

Screenshots or Videos

image

Greptile Summary

This PR adds a Crawlab (distributed web crawler management platform) template to the blueprint collection, deploying a master node backed by MongoDB. While the core concept and meta.json entry are solid, the docker-compose.yml and template.toml have several violations of the mandatory Dokploy contribution conventions that need to be resolved before merging.

Issues found:

  • Compose version (docker-compose.yml line 1): Must be "3.8", not "3.3".
  • container_name must be removed (docker-compose.yml line 6): Dokploy manages container naming; explicit names cause conflicts.
  • ports must be replaced with expose (docker-compose.yml lines 20–22): External port routing is handled by Dokploy's proxy — using ports bypasses this.
  • Service name mismatch (docker-compose.yml line 4): The service is named master but must exactly match the blueprint folder name crawlab. The serviceName in template.toml must be updated accordingly.
  • Invalid env var format in template.toml (lines 11–13): The [config.env] object subtable syntax is not supported — must use an array of strings under [config].
  • Unpinned image tag (crawlabteam/crawlab:latest): Should be pinned to a specific release to prevent silent upstream changes and supply chain risk. The version in meta.json must then be updated to match.

Confidence Score: 2/5

Not safe to merge — multiple mandatory Dokploy conventions are violated in both docker-compose.yml and template.toml.

There are four P1 violations in docker-compose.yml (wrong Compose version, forbidden container_name, forbidden ports, wrong service name) and one P1 violation in template.toml (invalid env var syntax), all explicitly required by the project AGENTS.md guide. These will result in incorrect or broken deployments.

blueprints/crawlab/docker-compose.yml and blueprints/crawlab/template.toml both need corrections before merging.

Important Files Changed
Filename Overview
blueprints/crawlab/docker-compose.yml Multiple violations of required Dokploy conventions: wrong Compose version (3.3 instead of 3.8), forbidden container_name and ports directives, service name (master) doesn't match blueprint folder name (crawlab), and the main image uses unpinned latest tag.
blueprints/crawlab/template.toml Environment variables are declared using invalid object syntax ([config.env] subtable) instead of the required array-of-strings format. The serviceName also needs updating once the service is renamed to match the folder.
meta.json Entry is well-formed with all required fields, correct id matching the folder name, valid links, and appropriate tags. The version: latest mirrors the unpinned image tag and should be updated when the image is pinned.

Reviews (1): Last reviewed commit: "feat: add crawlab - re order" | Re-trigger Greptile

Greptile also left 6 inline comments on this PR.

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

Context used:

  • Context used - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/759 **Author:** [@spacewaterbear](https://github.com/spacewaterbear) **Created:** 3/28/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `crawlab` --- ### 📝 Commits (4) - [`57c094d`](https://github.com/Dokploy/templates/commit/57c094d6c1868699980533ba317f0fc7c5f804ca) feat: add crawlab - [`bfd8fa3`](https://github.com/Dokploy/templates/commit/bfd8fa3268aef78695d2c2025c1827e6d909cc96) feat: add crawlab - re order - [`f24ccf6`](https://github.com/Dokploy/templates/commit/f24ccf69ac5f663f69fd0078ddcd7d62b78dd01d) feat: add crawlab - fix compose - [`a9c5b30`](https://github.com/Dokploy/templates/commit/a9c5b30aa5c5a95dedce83b901f6ff6746bec2f7) feat: split crawlab into worker and master ### 📊 Changes **7 files changed** (+116 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `blueprints/crawlab-master/crawlab.jpeg` (+0 -0) ➕ `blueprints/crawlab-master/docker-compose.yml` (+41 -0) ➕ `blueprints/crawlab-master/template.toml` (+12 -0) ➕ `blueprints/crawlab-worker/crawlab.jpeg` (+0 -0) ➕ `blueprints/crawlab-worker/docker-compose.yml` (+20 -0) ➕ `blueprints/crawlab-worker/template.toml` (+7 -0) 📝 `meta.json` (+36 -18) </details> ### 📄 Description ## What is this PR about? New PR of Crawlab (crawler management plateform) ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [ x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [ x] I have added tests that demonstrate that my correction works or that my new feature works. ## Issues related (if applicable) Close automatically the related issues using the keywords: `closes #ISSUE_NUMBER` ## Screenshots or Videos <img width="1035" height="639" alt="image" src="https://github.com/user-attachments/assets/dbd929ed-e507-4fda-8bd4-95794cf7f7b1" /> <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR adds a Crawlab (distributed web crawler management platform) template to the blueprint collection, deploying a master node backed by MongoDB. While the core concept and `meta.json` entry are solid, the `docker-compose.yml` and `template.toml` have several violations of the mandatory Dokploy contribution conventions that need to be resolved before merging. **Issues found:** - **Compose version** (`docker-compose.yml` line 1): Must be `"3.8"`, not `"3.3"`. - **`container_name` must be removed** (`docker-compose.yml` line 6): Dokploy manages container naming; explicit names cause conflicts. - **`ports` must be replaced with `expose`** (`docker-compose.yml` lines 20–22): External port routing is handled by Dokploy's proxy — using `ports` bypasses this. - **Service name mismatch** (`docker-compose.yml` line 4): The service is named `master` but must exactly match the blueprint folder name `crawlab`. The `serviceName` in `template.toml` must be updated accordingly. - **Invalid env var format in `template.toml`** (lines 11–13): The `[config.env]` object subtable syntax is not supported — must use an array of strings under `[config]`. - **Unpinned image tag** (`crawlabteam/crawlab:latest`): Should be pinned to a specific release to prevent silent upstream changes and supply chain risk. The `version` in `meta.json` must then be updated to match. <h3>Confidence Score: 2/5</h3> Not safe to merge — multiple mandatory Dokploy conventions are violated in both docker-compose.yml and template.toml. There are four P1 violations in docker-compose.yml (wrong Compose version, forbidden container_name, forbidden ports, wrong service name) and one P1 violation in template.toml (invalid env var syntax), all explicitly required by the project AGENTS.md guide. These will result in incorrect or broken deployments. blueprints/crawlab/docker-compose.yml and blueprints/crawlab/template.toml both need corrections before merging. <details><summary><h3>Important Files Changed</h3></summary> | Filename | Overview | |----------|----------| | blueprints/crawlab/docker-compose.yml | Multiple violations of required Dokploy conventions: wrong Compose version (3.3 instead of 3.8), forbidden container_name and ports directives, service name (master) doesn't match blueprint folder name (crawlab), and the main image uses unpinned latest tag. | | blueprints/crawlab/template.toml | Environment variables are declared using invalid object syntax ([config.env] subtable) instead of the required array-of-strings format. The serviceName also needs updating once the service is renamed to match the folder. | | meta.json | Entry is well-formed with all required fields, correct id matching the folder name, valid links, and appropriate tags. The version: latest mirrors the unpinned image tag and should be updated when the image is pinned. | </details> </details> <sub>Reviews (1): Last reviewed commit: ["feat: add crawlab - re order"](https://github.com/dokploy/templates/commit/bfd8fa3268aef78695d2c2025c1827e6d909cc96) | [Re-trigger Greptile](https://app.greptile.com/api/retrigger?id=26650900)</sub> > Greptile also left **6 inline comments** on this PR. <sub>(2/5) Greptile learns from your feedback when you react with thumbs up/down!</sub> **Context used:** - Context used - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=09330bde-2058-497c-9c64-ceae637fb5b2)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 11:33:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#1289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?