github-starred/templates
2
0
Fork 1
mirror of https://github.com/Dokploy/templates.git synced 2026-07-16 04:48:50 -05:00
Code Issues 2.9k Packages Projects Releases Wiki Activity

[PR #719] [CLOSED] fix(linkstack): make timezone configurable and remove invalid mounts #10776

New Issue
Closed
opened 2026-06-07 21:21:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-07 21:21:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/Dokploy/templates/pull/719
Author: @madhuragrawal
Created: 2/21/2026
Status: ❌ Closed

Base: canary ← Head: linkstack-fix-timezone-mount

📝 Commits (1)

  • 8f84dc8 fix(linkstack): make timezone configurable and remove invalid mounts

📊 Changes

2 files changed (+4 additions, -11 deletions)

View changed files

📝 blueprints/linkstack/docker-compose.yml (+1 -1)
📝 blueprints/linkstack/template.toml (+3 -10)

📄 Description

What is this PR about?

New PR of linkstack

This PR improves the Linkstack template by:

  • Exposing timezone as a configurable variable instead of a static default
  • Removing invalid volume mounts from template.toml that caused validation failures

The Docker Compose configuration already defines volumes, so removing the mounts from
template.toml aligns the template with repository conventions.

Checklist

Before submitting this PR, please make sure that:

No automated tests exist for templates; change verified via manual deployment.

Issues related (if applicable)

N/A

Greptile Summary

Made timezone configurable and fixed template validation issues

  • Replaced hardcoded Europe/Berlin timezone with configurable timezone variable (defaults to UTC)
  • Removed invalid mount configurations from template.toml that lacked required serviceName field
  • Volumes remain properly configured in docker-compose.yml

Confidence Score: 5/5

  • Safe to merge - fixes validation issues and improves configurability
  • Changes correctly address template validation failures by removing invalid mount configurations, make timezone user-configurable with a sensible default, and maintain all existing functionality. Volumes are properly defined in docker-compose.yml.
  • No files require special attention

Last reviewed commit: 8f84dc8

(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Dokploy/templates/pull/719 **Author:** [@madhuragrawal](https://github.com/madhuragrawal) **Created:** 2/21/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `linkstack-fix-timezone-mount` --- ### 📝 Commits (1) - [`8f84dc8`](https://github.com/Dokploy/templates/commit/8f84dc86369632459d1ba8f943dfc87d43a3c9d1) fix(linkstack): make timezone configurable and remove invalid mounts ### 📊 Changes **2 files changed** (+4 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `blueprints/linkstack/docker-compose.yml` (+1 -1) 📝 `blueprints/linkstack/template.toml` (+3 -10) </details> ### 📄 Description ## What is this PR about? New PR of linkstack This PR improves the Linkstack template by: - Exposing timezone as a configurable variable instead of a static default - Removing invalid volume mounts from `template.toml` that caused validation failures The Docker Compose configuration already defines volumes, so removing the mounts from `template.toml` aligns the template with repository conventions. ## Checklist Before submitting this PR, please make sure that: - [x] I have read the suggestions in the README.md file https://github.com/Dokploy/templates?tab=readme-ov-file#general-requirements-when-creating-a-template - [x] I have tested the template in my instance, so the maintainers don't spend time trying to figure out what's wrong. - [x] I have added tests that demonstrate that my correction works or that my new feature works. No automated tests exist for templates; change verified via manual deployment. ## Issues related (if applicable) N/A <!-- greptile_comment --> <h3>Greptile Summary</h3> Made timezone configurable and fixed template validation issues - Replaced hardcoded `Europe/Berlin` timezone with configurable `timezone` variable (defaults to UTC) - Removed invalid mount configurations from `template.toml` that lacked required `serviceName` field - Volumes remain properly configured in `docker-compose.yml` <h3>Confidence Score: 5/5</h3> - Safe to merge - fixes validation issues and improves configurability - Changes correctly address template validation failures by removing invalid mount configurations, make timezone user-configurable with a sensible default, and maintain all existing functionality. Volumes are properly defined in docker-compose.yml. - No files require special attention <sub>Last reviewed commit: 8f84dc8</sub> <!-- greptile_other_comments_section --> <sub>(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!</sub> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-07 21:21:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
pull-request
Mirrored from GitHub Pull Request
 template
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/templates#10776
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?