[GH-ISSUE #665] Suggestion: Rename positive digit in the EBNF ruleset to nonzero digit #7430

New Issue

GiteaMirror · 2026-06-20T17:29:50-05:00

GiteaMirror commented

2026-06-20 17:29:50 -05:00

Originally created by @dtonhofer on GitHub (Feb 22, 2021).
Original GitHub issue: https://github.com/semver/semver/issues/665

I suggest to rename the positive digit in the EBNF ruleset to nonzero digit

Because "positive" is not really an adjective applicable to a "digit": it's a digit, not a number.

So we have the digit "zero" expressed by "0" and the other digits, the nonzero digits

Originally created by @dtonhofer on GitHub (Feb 22, 2021). Original GitHub issue: https://github.com/semver/semver/issues/665 I suggest to rename the `positive digit` in the EBNF ruleset to `nonzero digit` Because "positive" is not really an adjective applicable to a "digit": it's a digit, not a number. So we have the digit "zero" expressed by `"0"` and the other digits, the `nonzero digit`s

GiteaMirror added the question update labels 2026-06-20 17:29:50 -05:00

GiteaMirror commented

2026-06-20 17:29:51 -05:00

@ghost commented on GitHub (Feb 26, 2021):

This is pretty easy to fix and mathematically correct. @dtonhofer do you mind putting in a PR?

@ghost commented on GitHub (Feb 26, 2021): This is pretty easy to fix and mathematically correct. @dtonhofer do you mind putting in a PR?

GiteaMirror commented

2026-06-20 17:29:52 -05:00

@dtonhofer commented on GitHub (Feb 26, 2021):

Okay, will do it later today (hopefully).

@dtonhofer commented on GitHub (Feb 26, 2021): Okay, will do it later today (hopefully).

GiteaMirror commented

2026-06-20 17:29:52 -05:00

@dtonhofer commented on GitHub (Feb 28, 2021):

Submitted a pull request.

https://github.com/semver/semver/pull/673

Note the following:

I have not upgrade the version at the top of the page, still at 2.0.0. Technically, should become 2.0.1 (?)
I have used the name non-zero digit rather than nonzero digit similar to the existing non-digit.It's a matter of taste.

@dtonhofer commented on GitHub (Feb 28, 2021): Submitted a pull request. https://github.com/semver/semver/pull/673 Note the following: - I have not upgrade the version at the top of the page, still at 2.0.0. Technically, should become 2.0.1 (?) - I have used the name `non-zero digit` rather than `nonzero digit` similar to the existing `non-digit`.It's a matter of taste.

GiteaMirror commented

2026-06-20 17:29:54 -05:00

@ghost commented on GitHub (Mar 1, 2021):

Yes, 2.0.1.

@ghost commented on GitHub (Mar 1, 2021): Yes, 2.0.1.

GiteaMirror commented

2026-06-20 17:29:54 -05:00

@dtonhofer commented on GitHub (Mar 1, 2021):

Changed. Seems to have updated the pull request accordingly.

@dtonhofer commented on GitHub (Mar 1, 2021): Changed. Seems to have updated the pull request accordingly.

GiteaMirror commented

2026-06-20 17:29:54 -05:00

@roniesha1994 commented on GitHub (Mar 21, 2022):

@roniesha1994 commented on GitHub (Mar 21, 2022): >

GiteaMirror commented

2026-06-20 17:29:55 -05:00

@dtonhofer commented on GitHub (Jul 5, 2022):

Good day. What happened to this? It seems to be in limbo. Accept? Reject?

@dtonhofer commented on GitHub (Jul 5, 2022): Good day. What happened to this? It seems to be in limbo. Accept? Reject?

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/semver#7430

[GH-ISSUE #665] Suggestion: Rename positive digit in the EBNF ruleset to nonzero digit #7430

[GH-ISSUE #665] Suggestion: Rename `positive digit` in the EBNF ruleset to `nonzero digit` #7430