[GH-ISSUE #55] How about some responsive design? #7018

Closed
opened 2026-06-20 16:37:22 -05:00 by GiteaMirror · 9 comments
Owner

Originally created by @pieroxy on GitHub (Nov 28, 2012).
Original GitHub issue: https://github.com/semver/semver/issues/55

The design for the spec could be enhanced by very few things:

  1. In main.css, change the body rule to :
    width: auto;
    margin: 0 10%;
    max-width: 710px;
  2. Adding the following meta element to the HEAD section of the html document: <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"/>
  3. Adding the following two rules to the stylesheet:
    @-ms-viewport { width: device-width; }
    html { -webkit-text-size-adjust: 100%; }

And ta-daaaa! The site works with all devices including those narrower than 710px wide. iPhones, Android, everything works, even resizing your browsers.

That said, nice work for the SemVer.

Originally created by @pieroxy on GitHub (Nov 28, 2012). Original GitHub issue: https://github.com/semver/semver/issues/55 The design for the spec could be enhanced by very few things: 1. In main.css, change the body rule to : width: auto; margin: 0 10%; max-width: 710px; 2. Adding the following meta element to the HEAD section of the html document: &lt;meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"/&gt; 3. Adding the following two rules to the stylesheet: @-ms-viewport { width: device-width; } html { -webkit-text-size-adjust: 100%; } And ta-daaaa! The site works with all devices including those narrower than 710px wide. iPhones, Android, everything works, even resizing your browsers. That said, nice work for the SemVer.
Author
Owner

@haacked commented on GitHub (Nov 28, 2012):

Nice suggestions! Could you submit the suggestions in the form of a pull request?

<!-- gh-comment-id:10811364 --> @haacked commented on GitHub (Nov 28, 2012): Nice suggestions! Could you submit the suggestions in the form of a pull request?
Author
Owner

@pieroxy commented on GitHub (Nov 29, 2012):

Will do as soon as I free up more than 5 contiguous minutes ;-)

<!-- gh-comment-id:10855932 --> @pieroxy commented on GitHub (Nov 29, 2012): Will do as soon as I free up more than 5 contiguous minutes ;-)
Author
Owner

@pieroxy commented on GitHub (Nov 30, 2012):

Well, I'm not sure I get it all. I'm new to GitHub so pardon me if I'm missing something big. I see only one file in the repo, which is an ascii version of the spec: semver.md

Which repo should I fork in order to make my suggested changes? I don't see any HTML or CSS files in there.

<!-- gh-comment-id:10879692 --> @pieroxy commented on GitHub (Nov 30, 2012): Well, I'm not sure I get it all. I'm new to GitHub so pardon me if I'm missing something big. I see only one file in the repo, which is an ascii version of the spec: semver.md Which repo should I fork in order to make my suggested changes? I don't see any HTML or CSS files in there.
Author
Owner

@pieroxy commented on GitHub (Nov 30, 2012):

Never mind, I got it.

<!-- gh-comment-id:10889534 --> @pieroxy commented on GitHub (Nov 30, 2012): Never mind, I got it.
Author
Owner

@pieroxy commented on GitHub (Nov 30, 2012):

Pull request submitted. And if I got it right, it might just work !

<!-- gh-comment-id:10890947 --> @pieroxy commented on GitHub (Nov 30, 2012): Pull request submitted. And if I got it right, it might just work !
Author
Owner

@haacked commented on GitHub (Dec 6, 2012):

Hi pieroxy, maybe I missed it, but I don't see the pull request.

<!-- gh-comment-id:11093493 --> @haacked commented on GitHub (Dec 6, 2012): Hi pieroxy, maybe I missed it, but I don't see the pull request.
Author
Owner

@pieroxy commented on GitHub (Dec 6, 2012):

I did it on the semver.org project...

https://github.com/mojombo/semver.org/pulls

<!-- gh-comment-id:11096531 --> @pieroxy commented on GitHub (Dec 6, 2012): I did it on the semver.org project... https://github.com/mojombo/semver.org/pulls
Author
Owner

@haacked commented on GitHub (Dec 6, 2012):

Oh, of course! Heh!

On Thu, Dec 6, 2012 at 10:03 AM, pieroxy notifications@github.com wrote:

I did it on the semver.org project...

https://github.com/mojombo/semver.org/pulls


Reply to this email directly or view it on GitHubhttps://github.com/mojombo/semver/issues/55#issuecomment-11096531.

<!-- gh-comment-id:11105913 --> @haacked commented on GitHub (Dec 6, 2012): Oh, of course! Heh! On Thu, Dec 6, 2012 at 10:03 AM, pieroxy notifications@github.com wrote: > I did it on the semver.org project... > > https://github.com/mojombo/semver.org/pulls > > — > Reply to this email directly or view it on GitHubhttps://github.com/mojombo/semver/issues/55#issuecomment-11096531.
Author
Owner

@haacked commented on GitHub (Dec 20, 2012):

Closing this one since there's a proper PR on the other one. I'll review that as soon as I figure out how to run it locally to try it out. :)

<!-- gh-comment-id:11555652 --> @haacked commented on GitHub (Dec 20, 2012): Closing this one since there's a proper PR on the other one. I'll review that as soon as I figure out how to run it locally to try it out. :)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/semver#7018