mirror of
https://github.com/semver/semver.git
synced 2026-07-10 19:50:47 -05:00
[GH-ISSUE #1068] Clarification (an additional FAQ entry) on documentation error. #5772
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dannyniu on GitHub (Dec 29, 2024).
Original GitHub issue: https://github.com/semver/semver/issues/1068
I'm setting up my workflow to the latest standard, and I bump into this problem.
What if my software code is correct, but its documentation is in error? Possible scenarios:
I asked this at here: https://softwareengineering.stackexchange.com/q/456161/290091 and I got answers. But what's not satisfactory is that, all the answers are considering documents as decoupled from the code, which I do not completely agree.
So ultimately, what should developers do to the version number, when the software is correct while the document/specification is wrong?
@dannyniu commented on GitHub (Dec 29, 2024):
Previously:
This is a completely different situation. The client code is already making non-existing assumption about the callee/dependency that only exist in docs.
@ljharb commented on GitHub (Dec 29, 2024):
I think it depends on the kind of error, and the consequences of correcting it - but either way, what the code actually does is far more important/impactful then what the docs say.
@masoudaflaki commented on GitHub (Jun 11, 2025):
Hi thanks for support and sponsor
@dannyniu commented on GitHub (Jun 13, 2025):
@ljharb The specific kind of error in question, is where the downstream "consumer code" depend on a documented behavior not present, or is different from that in the "provider code".
I think this might be most relevant.
@ljharb commented on GitHub (Jun 14, 2025):
That particular FAQ item is wrong imo; it shouldn’t say “minor”, it should say “non-major” or “patch”.
@steveklabnik commented on GitHub (Jun 16, 2025):
I'd agree with that.
@ljharb commented on GitHub (Jun 16, 2025):
→ #1128 to fix the FAQ