github-starred/semver
2
0
Fork 0
mirror of https://github.com/semver/semver.git synced 2026-07-11 03:53:53 -05:00
Code Issues 1.0k Packages Projects Releases 4 Wiki Activity

[GH-ISSUE #1021] Provided regexp matches <version core> "+" <build> "-" <pre-release> #5746

New Issue
Closed
opened 2026-06-15 12:16:53 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-06-15 12:16:53 -05:00
Owner
Copy Link

Originally created by @ykaliuta on GitHub (May 2, 2024).
Original GitHub issue: https://github.com/semver/semver/issues/1021

Looks like versions like 1.2.3+1-2 match the official regexp

/^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/gm

but it is not part of the spec

<valid semver> ::= <version core>
                 | <version core> "-" <pre-release>
                 | <version core> "+" <build>
                 | <version core> "-" <pre-release> "+" <build>
Originally created by @ykaliuta on GitHub (May 2, 2024). Original GitHub issue: https://github.com/semver/semver/issues/1021 Looks like versions like ```1.2.3+1-2``` match the official regexp ``` /^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/gm ``` but it is not part of the spec ``` <valid semver> ::= <version core> | <version core> "-" <pre-release> | <version core> "+" <build> | <version core> "-" <pre-release> "+" <build> ```
GiteaMirror commented 2026-06-15 12:16:55 -05:00
Author
Owner
Copy Link

@steveklabnik commented on GitHub (May 2, 2024):

This is the problem with trying to use a regex instead of a real parser. I imagine fixing this will be not particularly pretty.

<!-- gh-comment-id:2090957937 --> @steveklabnik commented on GitHub (May 2, 2024): This is the problem with trying to use a regex instead of a real parser. I imagine fixing this will be not particularly pretty.
GiteaMirror commented 2026-06-15 12:16:55 -05:00
Author
Owner
Copy Link

@zafarkhaja commented on GitHub (May 4, 2024):

but it is not part of the spec

It is part of the spec, you just need to go deeper into the <build> identifier.

<valid semver> ::= <version core> "+" <build>
<valid semver> ::= <version core> "+" <dot-separated build identifiers>
<valid semver> ::= <version core> "+" <build identifier>
<valid semver> ::= <version core> "+" <alphanumeric identifier>
<valid semver> ::= <version core> "+" <identifier characters> <non-digit> <identifier characters>
<valid semver> ::= <version core> "+" <identifier character> <non-digit> <identifier character>
<valid semver> ::= <version core> "+" <digit> <non-digit> <digit>
<valid semver> ::= <version core> "+" <digit> "-" <digit>
<!-- gh-comment-id:2094202671 --> @zafarkhaja commented on GitHub (May 4, 2024): > but it is not part of the spec It _is_ part of the spec, you just need to go deeper into the `<build>` identifier. <details> ```text <valid semver> ::= <version core> "+" <build> <valid semver> ::= <version core> "+" <dot-separated build identifiers> <valid semver> ::= <version core> "+" <build identifier> <valid semver> ::= <version core> "+" <alphanumeric identifier> <valid semver> ::= <version core> "+" <identifier characters> <non-digit> <identifier characters> <valid semver> ::= <version core> "+" <identifier character> <non-digit> <identifier character> <valid semver> ::= <version core> "+" <digit> <non-digit> <digit> <valid semver> ::= <version core> "+" <digit> "-" <digit> ``` </details>
GiteaMirror commented 2026-06-15 12:16:55 -05:00
Author
Owner
Copy Link

@ykaliuta commented on GitHub (May 6, 2024):

but it is not part of the spec

It is part of the spec, you just need to go deeper into the <build> identifier.

<valid semver> ::= <version core> "+" <build>
<valid semver> ::= <version core> "+" <dot-separated build identifiers>
<valid semver> ::= <version core> "+" <build identifier>
<valid semver> ::= <version core> "+" <alphanumeric identifier>
<valid semver> ::= <version core> "+" <identifier characters> <non-digit> <identifier characters>
<valid semver> ::= <version core> "+" <identifier character> <non-digit> <identifier character>
<valid semver> ::= <version core> "+" <digit> <non-digit> <digit>
<valid semver> ::= <version core> "+" <digit> "-" <digit>

True. Sorry for the noise

<!-- gh-comment-id:2096163383 --> @ykaliuta commented on GitHub (May 6, 2024): > > but it is not part of the spec > > It _is_ part of the spec, you just need to go deeper into the `<build>` identifier. > > ``` > <valid semver> ::= <version core> "+" <build> > <valid semver> ::= <version core> "+" <dot-separated build identifiers> > <valid semver> ::= <version core> "+" <build identifier> > <valid semver> ::= <version core> "+" <alphanumeric identifier> > <valid semver> ::= <version core> "+" <identifier characters> <non-digit> <identifier characters> > <valid semver> ::= <version core> "+" <identifier character> <non-digit> <identifier character> > <valid semver> ::= <version core> "+" <digit> <non-digit> <digit> > <valid semver> ::= <version core> "+" <digit> "-" <digit> > ``` True. Sorry for the noise
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
consensus seeking
duplicate
extend
layout
pull-request
Mirrored from GitHub Pull Request
 question
RFC
spelling/grammar
staled
update
waiting for PR
won't fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/semver#5746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?