mirror of
https://github.com/semver/semver.git
synced 2026-07-11 03:53:53 -05:00
[GH-ISSUE #66] http://semver.org/spec/v2.0.0-rc.1.html has v1.0.0-rc.1, is that intentional? #5169
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dmitshur on GitHub (Jan 30, 2013).
Original GitHub issue: https://github.com/semver/semver/issues/66
I noticed the commit
24eda4f61dfixed this issue, and http://semver.org has 2.0.0-rc.1 as expected.But if you manually navigate to http://semver.org/spec/v2.0.0-rc.1.html, it has 1.0.0-rc.1 there. Is that normal?
@haacked commented on GitHub (Mar 13, 2013):
Ha! I don't think so. Looks like a bug. The repository for semver.org is at https://github.com/mojombo/semver.org. Would you mind submitting a PR to fix it? You can do it all through the website even. :)
@dmitshur commented on GitHub (Mar 14, 2013):
Done. Updated with patch: https://github.com/mojombo/semver.org/pull/55
I'm not sure what you meant by "You can do it all through the website even. :)" though...
@haacked commented on GitHub (Mar 14, 2013):
I mean if you try and edit the page (I think this link will work https://github.com/mojombo/semver/edit/master/semver.md) GitHub will fork the project and provide an in-browser editor to make your change. When you make your commit, it'll send a pull request.
That way you don't have to clone things to your local machine for these non-code edits.
@dmitshur commented on GitHub (Mar 14, 2013):
Ah, I see what you meant now. I've used that feature in the past (e.g. here and here), it's super convenient! I just didn't realize that repo had the semver.org source that I could fix directly. It's obvious in hindsight now. :) Thanks!
@dmitshur commented on GitHub (Mar 14, 2013):
Damn, the problem with the website editor is that it automatically appends a newline which wasn't there before...
I guess I'll do it manually to avoid that problem.
Anyway, now there's a PR https://github.com/mojombo/semver.org/pull/55 with code to fix it. I got rid of the unintentional newline too. :)