mirror of
https://github.com/semver/semver.git
synced 2026-07-11 05:12:48 -05:00
No API interface breaking change only behavior change? Should I bump minor version or patch version? #470
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/semver#470
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @zamronypj on GitHub (Apr 28, 2021).
I introduce internal behavior change in API but API interface does not change. What version to bump? minor or patch?
@ljharb commented on GitHub (Apr 28, 2021):
Is the behavior something a consumer could rely on, in any way? If so, breaking. If not, patch.
@zamronypj commented on GitHub (Apr 29, 2021):
@ljharb To consumer of API, new behavior is more stable but with reduced performance. Is performance impact considered something a consumer rely on and warrant major version bump?
@ljharb commented on GitHub (Apr 29, 2021):
By default and in most cases, absolutely not. If you consider it a critical part of your project's API contract, then you might indeed want it to be major.
In any case tho, "same semantics" without any "new feature" isn't minor, it's patch or major.