github-starred/semver
2
0
Fork 0
mirror of https://github.com/semver/semver.git synced 2026-07-11 04:52:47 -05:00
Code Issues 1.0k Packages Projects Releases 4 Wiki Activity

[GH-ISSUE #150] Inconsistent language about build metadata and precedence #4341

New Issue
Closed
opened 2026-06-13 12:07:58 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-06-13 12:07:58 -05:00
Owner
Copy Link

Originally created by @toddreed on GitHub (Aug 8, 2013).
Original GitHub issue: https://github.com/semver/semver/issues/150

Section 10 states (emphasis added):

Build metadata SHOULD be ignored when determining version precedence.

And Section 11 states:

Build metadata does not figure into precedence.

For these statements to have greater consistency, I think Section 10 should state:

Build metadata MUST be ignored when determining version precedence.

Originally created by @toddreed on GitHub (Aug 8, 2013). Original GitHub issue: https://github.com/semver/semver/issues/150 Section 10 states (emphasis added): > Build metadata **SHOULD** be ignored when determining version precedence. And Section 11 states: > Build metadata **does not** figure into precedence. For these statements to have greater consistency, I think Section 10 should state: > Build metadata **MUST** be ignored when determining version precedence.
GiteaMirror commented 2026-06-13 12:07:59 -05:00
Author
Owner
Copy Link

@haacked commented on GitHub (Aug 8, 2013):

Yeah, I agree. Send a PR?

<!-- gh-comment-id:22356521 --> @haacked commented on GitHub (Aug 8, 2013): Yeah, I agree. Send a PR?
GiteaMirror commented 2026-06-13 12:08:00 -05:00
Author
Owner
Copy Link

@pvdb commented on GitHub (Aug 21, 2013):

Does merging #151 mean this ticket can be closed?

<!-- gh-comment-id:23032567 --> @pvdb commented on GitHub (Aug 21, 2013): Does merging #151 mean this ticket can be closed?
GiteaMirror commented 2026-06-13 12:08:02 -05:00
Author
Owner
Copy Link

@haacked commented on GitHub (Aug 21, 2013):

Yep!

<!-- gh-comment-id:23036699 --> @haacked commented on GitHub (Aug 21, 2013): Yep!
GiteaMirror commented 2026-06-13 12:08:03 -05:00
Author
Owner
Copy Link

@haacked commented on GitHub (Aug 21, 2013):

@toddreed for future reference, if you add "closes #150" Where 150 is the issue number, in your commit message or in the body of the pull request, it'll close the issue automatically when the PR is merged. :)

<!-- gh-comment-id:23036782 --> @haacked commented on GitHub (Aug 21, 2013): @toddreed for future reference, if you add "closes #150" Where 150 is the issue number, in your commit message or in the body of the pull request, it'll close the issue automatically when the PR is merged. :)
GiteaMirror commented 2026-06-13 12:08:05 -05:00
Author
Owner
Copy Link

@toddreed commented on GitHub (Aug 21, 2013):

@Haacked Ahh—thanks for the tip.

<!-- gh-comment-id:23048633 --> @toddreed commented on GitHub (Aug 21, 2013): @Haacked Ahh—thanks for the tip.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
consensus seeking
duplicate
extend
layout
pull-request
Mirrored from GitHub Pull Request
 question
RFC
spelling/grammar
staled
update
waiting for PR
won't fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/semver#4341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?