mirror of
https://github.com/semver/semver.git
synced 2026-07-11 03:53:53 -05:00
[PR #107] [MERGED] Section 9: Clarify pre-release definition #3838
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/semver/semver/pull/107
Author: @haacked
Created: 6/10/2013
Status: ✅ Merged
Merged: 6/10/2013
Merged by: @haacked
Base:
master← Head:clarify-prerelease📝 Commits (1)
dee96a6Section 9: Clarify pre-release definition📊 Changes
1 file changed (+9 additions, -8 deletions)
View changed files
📝
semver.md(+9 -8)📄 Description
This is cherry picked from #103 and related to #86
I'm actually not happy about removing the 'satisfies' usage.
If I understand @isaacs concern correctly, stating that
1.0.0-betasatisfies1.0.0implies a specific version range implementation and he is against that because other systems have different ways of specifying version ranges.For NuGet, we've taken to using the Maven range specification.
[1.0, 2.0)indicates a version that's1.0 or greater, but strictly less than 2.0According to SemVer as it is today,
1.0.0-betafits within that range. That's the intent of 'satisfies' even though it is less than1.0.0. The way I often think about it is when you allow pre-release versions in your dependency resolution,1.0.0can be considered1.0.0- ΩwhereΩhas a larger precedence than any valid pre-release version.I think we can get to a definition that expresses our intent without implying a specific implementation.
Something to the effect of:
^^^ The language there could be improved, but I think it hints at what I'm getting at. Pre-release is adding another dimension. Kind of like adding something to the y-axis while we've been looking at the x-axis all along.
How pre-release versions are "allowed" to be included is an implementation detail of the respective systems. For some, it might be indicated by the version range syntax. For others it's by passing a
-preflag into the system.What do you think?
/cc @isaacs, @tieske, @TimLovellSmith, @tbull, @jeffhandley
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.