github-starred/semver
2
0
Fork 0
mirror of https://github.com/semver/semver.git synced 2026-07-10 19:50:47 -05:00
Code Issues 1.0k Packages Projects Releases 4 Wiki Activity

[GH-ISSUE #695] No API interface breaking change only behavior change? Should I bump minor version or patch version? #2203

New Issue
Closed
opened 2026-04-20 10:12:13 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-20 10:12:13 -05:00
Owner
Copy Link

Originally created by @zamronypj on GitHub (Apr 28, 2021).
Original GitHub issue: https://github.com/semver/semver/issues/695

I introduce internal behavior change in API but API interface does not change. What version to bump? minor or patch?

Originally created by @zamronypj on GitHub (Apr 28, 2021). Original GitHub issue: https://github.com/semver/semver/issues/695 I introduce internal behavior change in API but API interface does not change. What version to bump? minor or patch?
GiteaMirror commented 2026-04-20 10:12:15 -05:00
Author
Owner
Copy Link

@ljharb commented on GitHub (Apr 28, 2021):

Is the behavior something a consumer could rely on, in any way? If so, breaking. If not, patch.

<!-- gh-comment-id:828845303 --> @ljharb commented on GitHub (Apr 28, 2021): Is the behavior something a consumer could rely on, in any way? If so, breaking. If not, patch.
GiteaMirror commented 2026-04-20 10:12:15 -05:00
Author
Owner
Copy Link

@zamronypj commented on GitHub (Apr 29, 2021):

@ljharb To consumer of API, new behavior is more stable but with reduced performance. Is performance impact considered something a consumer rely on and warrant major version bump?

<!-- gh-comment-id:829605690 --> @zamronypj commented on GitHub (Apr 29, 2021): @ljharb To consumer of API, new behavior is more stable but with reduced performance. Is performance impact considered something a consumer rely on and warrant major version bump?
GiteaMirror commented 2026-04-20 10:12:16 -05:00
Author
Owner
Copy Link

@ljharb commented on GitHub (Apr 29, 2021):

By default and in most cases, absolutely not. If you consider it a critical part of your project's API contract, then you might indeed want it to be major.

In any case tho, "same semantics" without any "new feature" isn't minor, it's patch or major.

<!-- gh-comment-id:829619641 --> @ljharb commented on GitHub (Apr 29, 2021): By default and in most cases, absolutely not. If you consider it a critical part of your project's API contract, then you might indeed want it to be major. In any case tho, "same semantics" without any "new feature" isn't minor, it's patch or major.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
consensus seeking
duplicate
extend
layout
pull-request
Mirrored from GitHub Pull Request
 question
RFC
spelling/grammar
staled
update
waiting for PR
won't fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/semver#2203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?