mirror of
https://github.com/semver/semver.git
synced 2026-07-11 06:53:03 -05:00
[GH-ISSUE #665] Suggestion: Rename positive digit in the EBNF ruleset to nonzero digit
#2189
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/semver#2189
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dtonhofer on GitHub (Feb 22, 2021).
Original GitHub issue: https://github.com/semver/semver/issues/665
I suggest to rename the
positive digitin the EBNF ruleset tononzero digitBecause "positive" is not really an adjective applicable to a "digit": it's a digit, not a number.
So we have the digit "zero" expressed by
"0"and the other digits, thenonzero digits@ghost commented on GitHub (Feb 26, 2021):
This is pretty easy to fix and mathematically correct. @dtonhofer do you mind putting in a PR?
@dtonhofer commented on GitHub (Feb 26, 2021):
Okay, will do it later today (hopefully).
@dtonhofer commented on GitHub (Feb 28, 2021):
Submitted a pull request.
https://github.com/semver/semver/pull/673
Note the following:
non-zero digitrather thannonzero digitsimilar to the existingnon-digit.It's a matter of taste.@ghost commented on GitHub (Mar 1, 2021):
Yes, 2.0.1.
@dtonhofer commented on GitHub (Mar 1, 2021):
Changed. Seems to have updated the pull request accordingly.
@roniesha1994 commented on GitHub (Mar 21, 2022):
@dtonhofer commented on GitHub (Jul 5, 2022):
Good day. What happened to this? It seems to be in limbo. Accept? Reject?