mirror of
https://github.com/semver/semver.git
synced 2026-07-11 04:52:47 -05:00
Example for build metadata does not comply with the spec itself #212
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @matthijskooijman on GitHub (Feb 20, 2016).
Section 10, about build metadata says:
Note that a period is not allowed in the build metadata according to this, but the last example does use periods in the build metadata (exp.sha.5114f85). This makes the section ambigious and confusing: Are periods allowed or not?
@FichteFoll commented on GitHub (Feb 20, 2016):
https://github.com/mojombo/semver/issues/291 https://github.com/mojombo/semver/issues/249 https://github.com/mojombo/semver/issues/230
@matthijskooijman commented on GitHub (Feb 20, 2016):
Heh, sorry for the noise. Should have read better, apparently. Perhaps the wording could be improved to make this more clear (having four tickets about this suggests that the wording might be improved), though I'm not quite sure what wording would be better. The current wording is pretty concise and accurate. Perhaps change the first sentence to:
Feel free to ignore this suggestion, but let it at least be my attempt to turn this ticket into something productive after all :-)
@haacked commented on GitHub (Feb 22, 2016):
Mind submitting that suggestion as a pull request?
@matthijskooijman commented on GitHub (Feb 22, 2016):
Willdo. Might not be until next week, though.
@matthijskooijman commented on GitHub (Mar 10, 2016):
@Haacked, done!
@efunkenbusch commented on GitHub (Aug 14, 2018):
I think I had to read the spec 5 times before I stopped skipping over the "dot separated" text. Just something about the way my brain parses the text and ignores what it considers to be fluff makes it not stand out. This, combined with the regex string makes it all too easy to miss. Seems a lot of other peoples brains work the same way.
But yeah, I think the text needs to be stated slightly different as well.
@alexandrtovmach commented on GitHub (Jun 10, 2020):
Thanks everyone for contributions, you're amazing 🎆 Did you find any consensus?
@FichteFoll commented on GitHub (Jun 11, 2020):
The result of this question is #296.