[GH-ISSUE #72] Text says "be comprised of" rather than "comprise" #1789

New Issue

GiteaMirror · 2026-04-20T09:23:30-05:00

GiteaMirror commented

2026-04-20 09:23:30 -05:00

Originally created by @vergenzt on GitHub (Mar 8, 2013).
Original GitHub issue: https://github.com/semver/semver/issues/72

In the Semantic Versioning Specification (2.0.0-rc1) in item 10, it states:

... Identifiers MUST be comprised of only ASCII alphanumerics and dash [0-9A-Za-z-].

This is the wrong word, as comprise means "to consist of; be made up of". The proper substitution should either be simply comprise or be composed of:

... Identifiers MUST comprise only ASCII alphanumerics and dash [0-9A-Za-z-].

Sorry to be a grammar Nazi, but this particular error always bugs me. =P

Originally created by @vergenzt on GitHub (Mar 8, 2013). Original GitHub issue: https://github.com/semver/semver/issues/72 In the Semantic Versioning Specification (2.0.0-rc1) in item 10, it states: > ... Identifiers MUST **be comprised of** only ASCII alphanumerics and dash [0-9A-Za-z-]. This is the wrong word, as _comprise_ means "to consist of; be made up of". The proper substitution should either be simply _comprise_ or _be composed of_: > ... Identifiers MUST **comprise** only ASCII alphanumerics and dash [0-9A-Za-z-]. Sorry to be a grammar Nazi, but this particular error always bugs me. =P

GiteaMirror closed this issue

2026-04-20 09:23:31 -05:00

GiteaMirror commented

2026-04-20 09:23:33 -05:00

@haacked commented on GitHub (Mar 8, 2013):

Care to send a pull request with the fix? You can do it all via the browser. :)

@haacked commented on GitHub (Mar 8, 2013): Care to send a pull request with the fix? You can do it all via the browser. :)

GiteaMirror commented

2026-04-20 09:23:35 -05:00

@haacked commented on GitHub (Mar 13, 2013):

This was fixed in 43252cc87e.

Pro Tip™: When you make a commit that fixes an issue, have the commit message say something like closes #123 where 123 is the issue number. That way when someone accepts the PR into their master branch, it closes the issue and cross references them. Pretty neat eh? 😄

@haacked commented on GitHub (Mar 13, 2013): This was fixed in 43252cc87ef9f72916eeb27bf68e462758b64780. Pro Tip™: When you make a commit that fixes an issue, have the commit message say something like `closes #123` where `123` is the issue number. That way when someone accepts the PR into their master branch, it closes the issue and cross references them. Pretty neat eh? :smile:

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/semver#1789