[GH-ISSUE #405] Weird alphanumeric-identifier grammar allowing "1.2.3----+----3.2.1" as a correct version number #1166

New Issue

GiteaMirror · 2026-04-16T10:27:14-05:00

GiteaMirror commented

2026-04-16 10:27:14 -05:00

Originally created by @nowox on GitHub (Nov 1, 2017).
Original GitHub issue: https://github.com/semver/semver/issues/405

I feel bizarre to allow - after the dash. The given grammar perfectly allows version such as

1.2.3----+----3.2.1

Is it really wanted?

Originally created by @nowox on GitHub (Nov 1, 2017). Original GitHub issue: https://github.com/semver/semver/issues/405 I feel bizarre to allow `-` after the `dash`. The given grammar perfectly allows version such as ``` 1.2.3----+----3.2.1 ``` Is it really wanted?

GiteaMirror added the won't fix label 2026-04-16 10:27:14 -05:00

GiteaMirror closed this issue

2026-04-16 10:27:15 -05:00

GiteaMirror commented

2026-04-16 10:27:17 -05:00

@akalongman commented on GitHub (Nov 1, 2017):

If developer is stupid, you can not fix that via specifications or rules :)

@akalongman commented on GitHub (Nov 1, 2017): If developer is stupid, you can not fix that via specifications or rules :)

GiteaMirror commented

2026-04-16 10:27:18 -05:00

@nowox commented on GitHub (Nov 1, 2017):

You can at least refuse the - which is confusing...

@nowox commented on GitHub (Nov 1, 2017): You can at least refuse the `-` which is confusing...

GiteaMirror commented

2026-04-16 10:27:19 -05:00

@jwdonahue commented on GitHub (Nov 28, 2017):

Hyphens are legal characters in prerelease and meta identifiers. There might actually be some automation out there that would generate such a perfectly valid version string, say, when the user failed to initialize some database/configuration fields.

This seems to be a duplicate of #360.

@jwdonahue commented on GitHub (Nov 28, 2017): Hyphens are legal characters in prerelease and meta identifiers. There might actually be some automation out there that would generate such a perfectly valid version string, say, when the user failed to initialize some database/configuration fields. This seems to be a duplicate of [#360](https://github.com/semver/semver/issues/360).

GiteaMirror commented

2026-04-16 10:27:20 -05:00

@jwdonahue commented on GitHub (Nov 28, 2017):

I believe this should be closed as won't fix. The tag identifiers are not empty and contain legal characters.

@jwdonahue commented on GitHub (Nov 28, 2017): I believe this should be closed as won't fix. The tag identifiers are not empty and contain legal characters.

GiteaMirror commented

2026-04-16 10:27:20 -05:00

@haacked commented on GitHub (Nov 29, 2017):

Not really wanted, but not really unwanted. Feels like it'd needlessly complicate the spec to clean this scenario up. Closing as "won't fix"

@haacked commented on GitHub (Nov 29, 2017): Not really wanted, but not really unwanted. Feels like it'd needlessly complicate the spec to clean this scenario up. Closing as "won't fix"

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/semver#1166