github-starred/semver
2
0
Fork 0
mirror of https://github.com/semver/semver.git synced 2026-07-11 06:53:03 -05:00
Code Issues 1.0k Packages Projects Releases 4 Wiki Activity

[GH-ISSUE #360] Leading or trailing hyphen in pre-release or build identifiers #1133

New Issue
Closed
opened 2026-04-16 10:23:31 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-16 10:23:31 -05:00
Owner
Copy Link

Originally created by @chrisowensboston on GitHub (Mar 22, 2017).
Original GitHub issue: https://github.com/semver/semver/issues/360

As written, the spec allows a pre-release or build identifier to begin or end with a hyphen.

As a result, the following pass the spec:

  • 2.1.7--43 (version is '2.1.7'; pre-release is '-43' )
  • 2.1.7+-43 (version is '2.1.7'; build identifier is '-43')
    Is this intended / desired?
Originally created by @chrisowensboston on GitHub (Mar 22, 2017). Original GitHub issue: https://github.com/semver/semver/issues/360 As written, the spec allows a pre-release or build identifier to begin or end with a hyphen. As a result, the following pass the spec: - 2.1.7--43 (version is '2.1.7'; pre-release is '-43' ) - 2.1.7+-43 (version is '2.1.7'; build identifier is '-43') Is this intended / desired?
GiteaMirror commented 2026-04-16 10:23:32 -05:00
Author
Owner
Copy Link

@FichteFoll commented on GitHub (Mar 23, 2017):

The following text is in both the pre-release and the build metadata sections:

Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty.

So yes, this is valid. They compare lexicographically (over their ASCII value), by the way.

<!-- gh-comment-id:288579984 --> @FichteFoll commented on GitHub (Mar 23, 2017): The following text is in both the pre-release and the build metadata sections: >Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]. Identifiers MUST NOT be empty. So yes, this is valid. They compare lexicographically (over their ASCII value), by the way.
GiteaMirror commented 2026-04-16 10:23:32 -05:00
Author
Owner
Copy Link

@jwdonahue commented on GitHub (Nov 28, 2017):

I would not expect to see any humans deciding to use version strings of that form, but I can imagine automation that might produce them, particularly if some config/database field is empty at the time it was generated. The hyphens may actually convey some meaning to somebody.

Since there is no bug or controversy here, please close this issue at your earliest possible convenience.

<!-- gh-comment-id:347668462 --> @jwdonahue commented on GitHub (Nov 28, 2017): I would not expect to see any humans deciding to use version strings of that form, but I can imagine automation that might produce them, particularly if some config/database field is empty at the time it was generated. The hyphens may actually convey some meaning to somebody. Since there is no bug or controversy here, please close this issue at your earliest possible convenience.
GiteaMirror commented 2026-04-16 10:23:33 -05:00
Author
Owner
Copy Link

@chrisowensboston commented on GitHub (Nov 28, 2017):

Closed as requested by jsdonahue: there is no bug or controversy here.

<!-- gh-comment-id:347700711 --> @chrisowensboston commented on GitHub (Nov 28, 2017): Closed as requested by jsdonahue: there is no bug or controversy here.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
consensus seeking
duplicate
extend
layout
pull-request
Mirrored from GitHub Pull Request
 question
RFC
spelling/grammar
staled
update
waiting for PR
won't fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/semver#1133
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?