From e3ea339279549e015463b40a08f672e3d180e3f4 Mon Sep 17 00:00:00 2001 From: DannyS712 <46829944+DannyS712@users.noreply.github.com> Date: Sun, 5 Apr 2020 01:24:45 -0700 Subject: [PATCH 1/3] Minor copyedit to CONTRIBUTING.md Add a missing "to", define the term "PR" (required making the sentence use the singular for parallelism with "RFC") --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ce27859..6be94ea 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ The "RFC" (request for comments) process is intended to provide a consistent and ## When you need to follow this process -You need to follow this process if you intend to make "substantial" changes to the specification or the RFC process itself. What constitutes a "substantial" change is evolving based on community norms and varies depending on what part of the specification you are proposing to change, but may include the following: +You need to follow this process if you intend to make "substantial" changes to the specification or to the RFC process itself. What constitutes a "substantial" change is evolving based on community norms and varies depending on what part of the specification you are proposing to change, but may include the following: * Changes to the meaning of the specification. @@ -15,9 +15,9 @@ Some changes do not require an RFC: ## What the process is -When pull requests are opened against the specification or this repository, they may be -tagged with an "RFC" tag ("RFC" from here forward). RFCs require the consensus of -all team members (see below) to merge. +When a pull request ("PR" from here forward) is opened against the specification or +this repository, it may be tagged with an "RFC" tag ("RFC" from here forward). +RFCs require the consensus of all team members (see below) to merge. ## The SemVer Team From 8aeb2c76219611dbefb284c8df14b61ea8a34059 Mon Sep 17 00:00:00 2001 From: DannyS712 <46829944+DannyS712@users.noreply.github.com> Date: Sun, 5 Apr 2020 01:25:43 -0700 Subject: [PATCH 2/3] Add a missing period to CODE_OF_CONDUCT.md The final sentence was missing a period --- CODE_OF_CONDUCT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 2c66e02..0403482 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -40,7 +40,7 @@ Project maintainers who do not follow or enforce the Code of Conduct in good fai ## Attribution -This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version] +This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]. [homepage]: http://contributor-covenant.org [version]: http://contributor-covenant.org/version/1/4/ From 5a2850504c2efff4c964e249f447545cd0680b8d Mon Sep 17 00:00:00 2001 From: DannyS712 <46829944+DannyS712@users.noreply.github.com> Date: Tue, 28 Apr 2020 22:02:13 -0700 Subject: [PATCH 3/3] Tweak Per review comment --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6be94ea..2957622 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -4,7 +4,7 @@ The "RFC" (request for comments) process is intended to provide a consistent and ## When you need to follow this process -You need to follow this process if you intend to make "substantial" changes to the specification or to the RFC process itself. What constitutes a "substantial" change is evolving based on community norms and varies depending on what part of the specification you are proposing to change, but may include the following: +You need to follow this process if you intend to make "substantial" changes to the specification or the RFC process itself. What constitutes a "substantial" change is evolving based on community norms and varies depending on what part of the specification you are proposing to change, but may include the following: * Changes to the meaning of the specification.