github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 09:21:15 -05:00
Code Issues 856 Packages Projects Releases 74 Wiki Activity

[PR #2603] [MERGED] fix: prevent resource from being created with dashboard's domain to avoid redirect loop #9835

New Issue
Closed
opened 2026-04-30 05:59:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 05:59:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2603
Author: @Fizza-Mukhtar
Created: 3/5/2026
Status: ✅ Merged
Merged: 3/8/2026
Merged by: @oschwartz10612

Base: main ← Head: fix/prevent-dashboard-domain-conflict-2595

📝 Commits (2)

  • 1a2069a fix: prevent resource creation with dashboard domain to avoid redirect loop
  • 4cfcc64 fix: use config instead of process.env for dashboard URL check

📊 Changes

3 files changed (+29 additions, -1 deletions)

View changed files

📝 server/routers/resource/createResource.ts (+14 -0)
📝 server/routers/resource/updateResource.ts (+14 -0)
📝 src/app/[orgId]/settings/resources/proxy/create/page.tsx (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Fixes #2595

Problem

Creating or updating a resource with the same subdomain as the dashboard caused an endless HTTP 302 redirect loop.

Fix

  • Added validation in createResource and updateResource to return a conflict error if the resource's full domain matches the dashboard URL
  • Updated the create resource page to show the actual backend error message instead of a generic one

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2603 **Author:** [@Fizza-Mukhtar](https://github.com/Fizza-Mukhtar) **Created:** 3/5/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix/prevent-dashboard-domain-conflict-2595` --- ### 📝 Commits (2) - [`1a2069a`](https://github.com/fosrl/pangolin/commit/1a2069a6d92f5bb5a03008966893ef3d4405c4b7) fix: prevent resource creation with dashboard domain to avoid redirect loop - [`4cfcc64`](https://github.com/fosrl/pangolin/commit/4cfcc64481f0b6c0c2f880ac41899661aa54a8b0) fix: use config instead of process.env for dashboard URL check ### 📊 Changes **3 files changed** (+29 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/resource/createResource.ts` (+14 -0) 📝 `server/routers/resource/updateResource.ts` (+14 -0) 📝 `src/app/[orgId]/settings/resources/proxy/create/page.tsx` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. Fixes #2595 ## Problem Creating or updating a resource with the same subdomain as the dashboard caused an endless HTTP 302 redirect loop. ## Fix - Added validation in `createResource` and `updateResource` to return a conflict error if the resource's full domain matches the dashboard URL - Updated the create resource page to show the actual backend error message instead of a generic one --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 05:59:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#9835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?