github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2574] [CLOSED] feat: add pageSize persistence to ControlledDataTable #9818

New Issue
Closed
opened 2026-04-30 05:58:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 05:58:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2574
Author: @LaurenceJJones
Created: 3/1/2026
Status: ❌ Closed

Base: main ← Head: fix/pagination-pagesize-reset

📝 Commits (2)

  • 11b6f50 feat: add pageSize persistence to ControlledDataTable
  • 73ae493 fix: add usememo as missed tsc

📊 Changes

4 files changed (+60 additions, -96 deletions)

View changed files

📝 src/components/ui/controlled-data-table.tsx (+34 -2)
📝 src/components/ui/data-table.tsx (+8 -83)
📝 src/hooks/useStoredColumnVisibility.ts (+6 -6)
📝 src/hooks/useStoredPageSize.ts (+12 -5)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

  • ControlledDataTable now persists pageSize to localStorage (default: true)
  • Refactored DataTable to use shared storage hooks
  • Exported getStoredPageSize/setStoredPageSize from useStoredPageSize
  • Exported getStoredColumnVisibility/setStoredColumnVisibility from useStoredColumnVisibility
  • Unified storage key format: datatable-{tableId}-page-size, datatable-{tableId}-column-visibility

How to test?

Page sizes or column visibility across data-table and controlled-data-table are now using the same hooks for persistence to local storage, this ensures storage naming schemes across the tables stay consistent, instead of each component owning the process. When altering the page size or column visibility on any data table this should be stored within local storage to ensure navigating away or coming back stays consistent.

The only issue we will have that previous data-table local storage items will be stale and not used since the newer scheme was datatable-${tableid} prefix, let me know if we should handle an automatic migration?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2574 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/1/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pagination-pagesize-reset` --- ### 📝 Commits (2) - [`11b6f50`](https://github.com/fosrl/pangolin/commit/11b6f50b5bbe24ba53d5ef52cfc90b9d93021136) feat: add pageSize persistence to ControlledDataTable - [`73ae493`](https://github.com/fosrl/pangolin/commit/73ae4930f37819ea30b2a13e09e314e27c3a7702) fix: add usememo as missed tsc ### 📊 Changes **4 files changed** (+60 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `src/components/ui/controlled-data-table.tsx` (+34 -2) 📝 `src/components/ui/data-table.tsx` (+8 -83) 📝 `src/hooks/useStoredColumnVisibility.ts` (+6 -6) 📝 `src/hooks/useStoredPageSize.ts` (+12 -5) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description - ControlledDataTable now persists pageSize to localStorage (default: true) - Refactored DataTable to use shared storage hooks - Exported getStoredPageSize/setStoredPageSize from useStoredPageSize - Exported getStoredColumnVisibility/setStoredColumnVisibility from useStoredColumnVisibility - Unified storage key format: datatable-{tableId}-page-size, datatable-{tableId}-column-visibility ## How to test? Page sizes or column visibility across data-table and controlled-data-table are now using the same hooks for persistence to local storage, this ensures storage naming schemes across the tables stay consistent, instead of each component owning the process. When altering the page size or column visibility on any data table this should be stored within local storage to ensure navigating away or coming back stays consistent. The only issue we will have that previous data-table local storage items will be stale and not used since the newer scheme was `datatable-${tableid}` prefix, let me know if we should handle an automatic migration? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 05:58:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#9818
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?