github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-07 21:30:36 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2570] [MERGED] fix: local targets ignored when newt site is unhealthy (mixed target failover) #9816

New Issue
Closed
opened 2026-04-30 05:58:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 05:58:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2570
Author: @Fizza-Mukhtar
Created: 3/1/2026
Status: ✅ Merged
Merged: 3/1/2026
Merged by: @oschwartz10612

Base: main ← Head: fix/mixed-target-failover-2448

📝 Commits (2)

  • f36cf06 fix: fallback to local targets when newt targets are unhealthy
  • e63a6e9 fix: treat local and wireguard sites as online for failover

📊 Changes

2 files changed (+18 additions, -6 deletions)

View changed files

📝 server/lib/traefik/getTraefikConfig.ts (+10 -4)
📝 server/private/lib/traefik/getTraefikConfig.ts (+8 -2)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Fixes #2448

Problem

Local targets were ignored when Newt targets became unhealthy because
local sites always have online=false and were excluded by the anySitesOnline check.

Fix

Added early return for local site type in the target filter so they are
always considered available as fallback servers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2570 **Author:** [@Fizza-Mukhtar](https://github.com/Fizza-Mukhtar) **Created:** 3/1/2026 **Status:** ✅ Merged **Merged:** 3/1/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix/mixed-target-failover-2448` --- ### 📝 Commits (2) - [`f36cf06`](https://github.com/fosrl/pangolin/commit/f36cf06e2624b66bf15a02ceea87fe7d3a86860d) fix: fallback to local targets when newt targets are unhealthy - [`e63a6e9`](https://github.com/fosrl/pangolin/commit/e63a6e9b77d747e2cc1542124d6f9691bef0edb1) fix: treat local and wireguard sites as online for failover ### 📊 Changes **2 files changed** (+18 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/traefik/getTraefikConfig.ts` (+10 -4) 📝 `server/private/lib/traefik/getTraefikConfig.ts` (+8 -2) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. Fixes #2448 ## Problem Local targets were ignored when Newt targets became unhealthy because local sites always have online=false and were excluded by the anySitesOnline check. ## Fix Added early return for local site type in the target filter so they are always considered available as fallback servers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 05:58:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#9816
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?