github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2537] [MERGED] fix: sync resource toggle states with context on initial load #9799

New Issue
Closed
opened 2026-04-30 05:57:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-30 05:57:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2537
Author: @Abhinav-kodes
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/toggle-hydration-sync

📝 Commits (1)

  • c600da7 fix: sync resource toggle states with context on initial load

📊 Changes

2 files changed (+20 additions, -6 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx (+13 -4)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/rules/page.tsx (+7 -2)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Fixes a hydration bug where the Enable Rules, SSO, and Email Whitelist toggles on resource settings pages would always render in the OFF state on cold load, regardless of the actual saved value in the database.

Closes fosrl/pangolin#2528

Root Cause

The SwitchInput components were using the defaultChecked prop (uncontrolled), which React only reads on the first render. Since the resource context hydrates asynchronously after mount, the first render always sees undefined or a stale value, so the toggles always appeared OFF.

Additionally, the state variables were initialized once via useState(resource.X) with no mechanism to re-sync when the context updated.

Changes

src/app/[orgId]/settings/resources/proxy/[niceId]/rules/page.tsx

  • useState(resource.applyRules ?? false) — added ?? false fallback
  • Added useEffect to sync rulesEnabled when resource.applyRules updates
  • Changed defaultChecked={rulesEnabled} → checked={rulesEnabled} (controlled)

src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx

  • useState(resource.sso ?? false) — added ?? false fallback
  • Added useEffect to sync ssoEnabled when resource.sso updates
  • Changed defaultChecked={resource.sso} → checked={ssoEnabled} (controlled)
  • useState(resource.emailWhitelistEnabled ?? false) — added ?? false fallback
  • Added useEffect to sync whitelistEnabled when resource.emailWhitelistEnabled updates
  • Changed defaultChecked={resource.emailWhitelistEnabled} → checked={whitelistEnabled} (controlled)

Before / After

Before: Toggle always renders OFF on hard refresh, even when DB value is true.
After: Toggle correctly reflects the saved DB value immediately on load.

Testing

  • Hard refresh (Ctrl+Shift+R) on a resource with applyRules = true → Rules toggle shows ON
  • Hard refresh on a resource with emailWhitelistEnabled = true → Whitelist toggle shows ON
  • Hard refresh on a resource with sso = true → SSO toggle shows ON
  • Toggling any switch and saving still works correctly
  • No React controlled/uncontrolled warnings in console

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2537 **Author:** [@Abhinav-kodes](https://github.com/Abhinav-kodes) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/toggle-hydration-sync` --- ### 📝 Commits (1) - [`c600da7`](https://github.com/fosrl/pangolin/commit/c600da71e3ffb873ba0ad27fe49363a44bccd9ae) fix: sync resource toggle states with context on initial load ### 📊 Changes **2 files changed** (+20 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx` (+13 -4) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/rules/page.tsx` (+7 -2) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Fixes a hydration bug where the **Enable Rules**, **SSO**, and **Email Whitelist** toggles on resource settings pages would always render in the OFF state on cold load, regardless of the actual saved value in the database. Closes fosrl/pangolin#2528 ## Root Cause The `SwitchInput` components were using the `defaultChecked` prop (uncontrolled), which React only reads on the **first render**. Since the resource context hydrates asynchronously after mount, the first render always sees `undefined` or a stale value, so the toggles always appeared OFF. Additionally, the state variables were initialized once via `useState(resource.X)` with no mechanism to re-sync when the context updated. ## Changes ### `src/app/[orgId]/settings/resources/proxy/[niceId]/rules/page.tsx` - `useState(resource.applyRules ?? false)` — added `?? false` fallback - Added `useEffect` to sync `rulesEnabled` when `resource.applyRules` updates - Changed `defaultChecked={rulesEnabled}` → `checked={rulesEnabled}` (controlled) ### `src/app/[orgId]/settings/resources/proxy/[niceId]/authentication/page.tsx` - `useState(resource.sso ?? false)` — added `?? false` fallback - Added `useEffect` to sync `ssoEnabled` when `resource.sso` updates - Changed `defaultChecked={resource.sso}` → `checked={ssoEnabled}` (controlled) - `useState(resource.emailWhitelistEnabled ?? false)` — added `?? false` fallback - Added `useEffect` to sync `whitelistEnabled` when `resource.emailWhitelistEnabled` updates - Changed `defaultChecked={resource.emailWhitelistEnabled}` → `checked={whitelistEnabled}` (controlled) ## Before / After **Before:** Toggle always renders OFF on hard refresh, even when DB value is `true`. **After:** Toggle correctly reflects the saved DB value immediately on load. ## Testing - [ ] Hard refresh (`Ctrl+Shift+R`) on a resource with `applyRules = true` → Rules toggle shows ON - [ ] Hard refresh on a resource with `emailWhitelistEnabled = true` → Whitelist toggle shows ON - [ ] Hard refresh on a resource with `sso = true` → SSO toggle shows ON - [ ] Toggling any switch and saving still works correctly - [ ] No React controlled/uncontrolled warnings in console ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-30 05:57:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#9799
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?