github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-03-12 09:54:16 -05:00
Code Issues 94 Packages Projects Releases 48 Wiki Activity

[PR #1113] [MERGED] Fix ESLint issues: prefer-const warnings and missing semicolons #958

New Issue
Closed
opened 2025-11-13 12:14:50 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-13 12:14:50 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1113
Author: @Copilot
Created: 7/22/2025
Status: ✅ Merged
Merged: 8/10/2025
Merged by: @oschwartz10612

Base: main ← Head: copilot/fix-1112

📝 Commits (10+)

  • b5afd73 Initial plan
  • 4f5091e Initial commit: Document plan to fix ESLint issues
  • 2259879 Fix ESLint issues: prefer-const warnings and missing semicolons
  • a2526ea Revert mappings variable from const to let in getAllRelays.ts
  • 27ac204 Fix variables incorrectly changed from let to const - revert to let where variables are reassigned
  • 4701da2 Fix a few consts to lets
  • e9e6b0b Merge branch 'main' into copilot/fix-1112
  • 0edb3cd Merge branch 'main' of github.com:fosrl/pangolin into copilot/fix-1112
  • c3723d0 Add semi
  • ea27075 Lint fix

📊 Changes

40 files changed (+52 additions, -51 deletions)

View changed files

📝 server/lib/ip.ts (+2 -2)
📝 server/lib/rateLimitStore.ts (+1 -1)
📝 server/routers/accessToken/listAccessTokens.ts (+1 -1)
📝 server/routers/gerbil/getAllRelays.ts (+2 -2)
📝 server/routers/gerbil/getConfig.ts (+1 -1)
📝 server/routers/idp/createOidcIdp.ts (+1 -1)
📝 server/routers/idp/updateOidcIdp.ts (+1 -1)
📝 server/routers/idp/validateOidcCallback.ts (+2 -2)
📝 server/routers/newt/handleNewtPingRequestMessage.ts (+1 -1)
📝 server/routers/olm/handleOlmPingMessage.ts (+2 -2)
📝 server/routers/olm/handleOlmRegisterMessage.ts (+1 -1)
📝 server/routers/resource/listResourceRules.ts (+2 -2)
📝 server/routers/resource/listResources.ts (+1 -1)
📝 server/routers/role/listRoles.ts (+1 -1)
📝 server/routers/site/listSites.ts (+1 -1)
📝 server/routers/site/pickSiteDefaults.ts (+1 -1)
📝 server/routers/target/helpers.ts (+3 -3)
📝 server/routers/target/listTargets.ts (+2 -2)
📝 server/routers/ws/ws.ts (+1 -1)
📝 server/setup/scriptsPg/1.6.0.ts (+1 -1)

...and 20 more files

📄 Description

This PR resolves all ESLint issues identified in the codebase by fixing prefer-const warnings and missing semicolon errors.

Issues Fixed

Before:

  • 66 prefer-const warnings - variables declared with let that are never reassigned
  • 4 missing semicolon errors
  • Total: 70 ESLint problems

After:

  • 0 ESLint warnings or errors ✅

Changes Made

Automated Fixes (ESLint --fix)

  • Used ESLint's built-in --fix capability to automatically resolve 58 out of 70 issues
  • Changed let to const for variables that are never reassigned across server routers and React components
  • Added missing semicolons in error-prone locations

Manual Fixes

  • Fixed remaining 12 prefer-const warnings in migration scripts where ESLint couldn't auto-fix due to declaration/assignment separation
  • Consolidated variable declarations like: 
    // Before
let rawConfig: any;
rawConfig = yaml.load(fileContents);

// After  
const rawConfig: any = yaml.load(fileContents);

Files Modified

  • 39 files across server/ and src/ directories
  • Server routers: API endpoints, authentication, and business logic
  • Setup scripts: Database migration scripts
  • React components: UI pages and forms

Impact

  • No functional changes - all modifications are code style improvements only
  • Improved code quality - follows TypeScript/ESLint best practices
  • Better maintainability - clearer intent with const vs let usage

Verification

  • ✅ ESLint passes with zero warnings/errors
  • ✅ TypeScript syntax validation confirms changes are correct
  • ✅ All changes are minimal and surgical (38 insertions, 38 deletions)

Fixes #1112.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build (dns block)
  • scarf.sh
    • Triggering command: node ./report.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1113 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 8/10/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `copilot/fix-1112` --- ### 📝 Commits (10+) - [`b5afd73`](https://github.com/fosrl/pangolin/commit/b5afd7302475abc58cef5bf6ea9d6285992da382) Initial plan - [`4f5091e`](https://github.com/fosrl/pangolin/commit/4f5091ed7f9342c9407411f19b39013750483a87) Initial commit: Document plan to fix ESLint issues - [`2259879`](https://github.com/fosrl/pangolin/commit/2259879595da744ace17172e1815182b06313d8a) Fix ESLint issues: prefer-const warnings and missing semicolons - [`a2526ea`](https://github.com/fosrl/pangolin/commit/a2526ea2441a47e666f21afed2990af13c615f98) Revert mappings variable from const to let in getAllRelays.ts - [`27ac204`](https://github.com/fosrl/pangolin/commit/27ac204bb6adc8adf748077f86a47633671aee27) Fix variables incorrectly changed from let to const - revert to let where variables are reassigned - [`4701da2`](https://github.com/fosrl/pangolin/commit/4701da201d83b9a005909a267bb10eeacd81691c) Fix a few consts to lets - [`e9e6b0b`](https://github.com/fosrl/pangolin/commit/e9e6b0bc4fc8d26452212fd7874811d7c1c4b46f) Merge branch 'main' into copilot/fix-1112 - [`0edb3cd`](https://github.com/fosrl/pangolin/commit/0edb3cd3163c03a32aace995561bc50e476b1b35) Merge branch 'main' of github.com:fosrl/pangolin into copilot/fix-1112 - [`c3723d0`](https://github.com/fosrl/pangolin/commit/c3723d0fce1b60094d8d32e61a330a0bed9a1e8a) Add semi - [`ea27075`](https://github.com/fosrl/pangolin/commit/ea27075babe8201bfece242f1d14d1611e33afd9) Lint fix ### 📊 Changes **40 files changed** (+52 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/ip.ts` (+2 -2) 📝 `server/lib/rateLimitStore.ts` (+1 -1) 📝 `server/routers/accessToken/listAccessTokens.ts` (+1 -1) 📝 `server/routers/gerbil/getAllRelays.ts` (+2 -2) 📝 `server/routers/gerbil/getConfig.ts` (+1 -1) 📝 `server/routers/idp/createOidcIdp.ts` (+1 -1) 📝 `server/routers/idp/updateOidcIdp.ts` (+1 -1) 📝 `server/routers/idp/validateOidcCallback.ts` (+2 -2) 📝 `server/routers/newt/handleNewtPingRequestMessage.ts` (+1 -1) 📝 `server/routers/olm/handleOlmPingMessage.ts` (+2 -2) 📝 `server/routers/olm/handleOlmRegisterMessage.ts` (+1 -1) 📝 `server/routers/resource/listResourceRules.ts` (+2 -2) 📝 `server/routers/resource/listResources.ts` (+1 -1) 📝 `server/routers/role/listRoles.ts` (+1 -1) 📝 `server/routers/site/listSites.ts` (+1 -1) 📝 `server/routers/site/pickSiteDefaults.ts` (+1 -1) 📝 `server/routers/target/helpers.ts` (+3 -3) 📝 `server/routers/target/listTargets.ts` (+2 -2) 📝 `server/routers/ws/ws.ts` (+1 -1) 📝 `server/setup/scriptsPg/1.6.0.ts` (+1 -1) _...and 20 more files_ </details> ### 📄 Description This PR resolves all ESLint issues identified in the codebase by fixing `prefer-const` warnings and missing semicolon errors. ## Issues Fixed **Before:** - 66 `prefer-const` warnings - variables declared with `let` that are never reassigned - 4 missing semicolon errors - Total: 70 ESLint problems **After:** - 0 ESLint warnings or errors ✅ ## Changes Made ### Automated Fixes (ESLint --fix) - Used ESLint's built-in `--fix` capability to automatically resolve 58 out of 70 issues - Changed `let` to `const` for variables that are never reassigned across server routers and React components - Added missing semicolons in error-prone locations ### Manual Fixes - Fixed remaining 12 `prefer-const` warnings in migration scripts where ESLint couldn't auto-fix due to declaration/assignment separation - Consolidated variable declarations like: ```typescript // Before let rawConfig: any; rawConfig = yaml.load(fileContents); // After const rawConfig: any = yaml.load(fileContents); ``` ## Files Modified - **39 files** across `server/` and `src/` directories - **Server routers:** API endpoints, authentication, and business logic - **Setup scripts:** Database migration scripts - **React components:** UI pages and forms ## Impact - **No functional changes** - all modifications are code style improvements only - **Improved code quality** - follows TypeScript/ESLint best practices - **Better maintainability** - clearer intent with `const` vs `let` usage ## Verification - ✅ ESLint passes with zero warnings/errors - ✅ TypeScript syntax validation confirms changes are correct - ✅ All changes are minimal and surgical (38 insertions, 38 deletions) Fixes #1112. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `fonts.googleapis.com` > - Triggering command: `node /home/REDACTED/work/pangolin/pangolin/node_modules/.bin/next build` (dns block) > - `scarf.sh` > - Triggering command: `node ./report.js` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to my [firewall allow list](https://gh.io/copilot/firewall-config) > > </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-13 12:14:50 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?