github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 21:59:09 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[GH-ISSUE #2283] Deletion confirmation function is not working #8891

New Issue
Closed
opened 2026-04-30 04:59:49 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-30 04:59:49 -05:00
Owner
Copy Link

Originally created by @wangfeng28 on GitHub (Jan 20, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2283

Describe the Bug

I just tested the deletion confirmation function, Sites, Resources Public/Private, Domains, Users... Although they all have "Enter Confirmation" input boxes on the UI, the actual situation is that if I do not enter the confirmation information, or even enter the wrong confirmation information, the deletion will be performed immediately when I click the delete button.

Environment

  • OS Type & Version: macOS
  • Pangolin Version: v1.14.1
  • Browser: Safari & Firefox

To Reproduce

  1. Open URL: https://pangolin.server/settings/resources/proxy
  2. Click "..."
  3. Click “Delete”
  4. Type wrong confirmation text and Click “Confirm Delete Resource", or Just Click “Confirm Delete Resource" with out enter any confirmation text.

Expected Behavior

User needs to enter the correct confirmation text to delete the resource.

Originally created by @wangfeng28 on GitHub (Jan 20, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2283 ### Describe the Bug I just tested the deletion confirmation function, Sites, Resources Public/Private, Domains, Users... Although they all have "Enter Confirmation" input boxes on the UI, the actual situation is that if I do not enter the confirmation information, or even enter the wrong confirmation information, the deletion will be performed immediately when I click the delete button. ### Environment - OS Type & Version: macOS - Pangolin Version: v1.14.1 - Browser: Safari & Firefox ### To Reproduce 1. Open URL: https://pangolin.server/settings/resources/proxy 2. Click "..." 3. Click “Delete” 4. Type wrong confirmation text and Click “Confirm Delete Resource", or Just Click “Confirm Delete Resource" with out enter any confirmation text. ### Expected Behavior User needs to enter the correct confirmation text to delete the resource.
GiteaMirror commented 2026-04-30 04:59:50 -05:00
Author
Owner
Copy Link

@K0lin commented on GitHub (Jan 20, 2026):

@oschwartz10612 may i work on it?

<!-- gh-comment-id:3773479330 --> @K0lin commented on GitHub (Jan 20, 2026): @oschwartz10612 may i work on it?
GiteaMirror commented 2026-04-30 04:59:50 -05:00
Author
Owner
Copy Link

@K0lin commented on GitHub (Jan 20, 2026):

After some further investigation, I can confirm that the issue has already been resolved with PR #2172 , and I imagine it will be effective for everyone from the next release onwards

<!-- gh-comment-id:3773671747 --> @K0lin commented on GitHub (Jan 20, 2026): After some further investigation, I can confirm that the issue has already been resolved with PR #2172 , and I imagine it will be effective for everyone from the next release onwards
GiteaMirror commented 2026-04-30 04:59:51 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jan 20, 2026):

Yeah @K0lin is right I think it was already resolved! 😄

<!-- gh-comment-id:3774213758 --> @oschwartz10612 commented on GitHub (Jan 20, 2026): Yeah @K0lin is right I think it was already resolved! 😄
GiteaMirror commented 2026-04-30 04:59:51 -05:00
Author
Owner
Copy Link

@wangfeng28 commented on GitHub (Jan 20, 2026):

Thanks for your amazing works, guys!

<!-- gh-comment-id:3775306376 --> @wangfeng28 commented on GitHub (Jan 20, 2026): Thanks for your amazing works, guys!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#8891
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?