[GH-ISSUE #1686] Rule priority doesn't update properly #8740

Closed
opened 2026-04-30 04:45:44 -05:00 by GiteaMirror · 4 comments
Owner

Originally created by @matt01y on GitHub (Oct 17, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/1686

Originally assigned to: @Pallavikumarimdb on GitHub.

Describe the Bug

If only the up/down arrow are used to change the priority integer. The priorities don't update when saving.

Environment

  • OS Type & Version: Docker on Truenas (debian)
  • Pangolin Version: 1.11.0 (was also on earlier versions)
  • Gerbil Version: 1.2.2
  • Traefik Version: 3.5.3
  • Newt Version: N/A using local site

To Reproduce

When updating rule priorities by only pressing the up/down arrows the priorities don't update when pressing save all settings

Except when you first put your cursor (mouse click on cell) again on the number.

Expected Behavior

Values update when just using the up/down arrows.

Originally created by @matt01y on GitHub (Oct 17, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/1686 Originally assigned to: @Pallavikumarimdb on GitHub. ### Describe the Bug If only the up/down arrow are used to change the priority integer. The priorities don't update when saving. ### Environment - OS Type & Version: Docker on Truenas (debian) - Pangolin Version: 1.11.0 (was also on earlier versions) - Gerbil Version: 1.2.2 - Traefik Version: 3.5.3 - Newt Version: N/A using local site ### To Reproduce When updating rule priorities by only pressing the up/down arrows the priorities don't update when pressing `save all settings` Except when you first put your cursor (mouse click on cell) again on the number. ### Expected Behavior Values update when just using the up/down arrows.
GiteaMirror added the bug label 2026-04-30 04:45:44 -05:00
Author
Owner

@oschwartz10612 commented on GitHub (Oct 17, 2025):

@Pallavikumarimdb could you look at this one as well? I bet this is react related because the input has not been "touched".

<!-- gh-comment-id:3416458492 --> @oschwartz10612 commented on GitHub (Oct 17, 2025): @Pallavikumarimdb could you look at this one as well? I bet this is react related because the input has not been "touched".
Author
Owner

@Pallavikumarimdb commented on GitHub (Oct 17, 2025):

@oschwartz10612 sure👍

<!-- gh-comment-id:3416471894 --> @Pallavikumarimdb commented on GitHub (Oct 17, 2025): @oschwartz10612 sure👍
Author
Owner

@Pallavikumarimdb commented on GitHub (Oct 18, 2025):

This isn’t a bug - it’s expected browser behavior.
The up/down arrows on a number input don’t trigger a change event unless the input is focused.
You need to first click inside the field (to focus it) before using the arrows for the updated value to be registered when saving.

I’ve added an improvement (onClick={(e) => e.currentTarget.focus()}) to ensure the input auto-focuses when clicked, so the behavior feels more intuitive.

<!-- gh-comment-id:3418718990 --> @Pallavikumarimdb commented on GitHub (Oct 18, 2025): This isn’t a bug - it’s expected browser behavior. The up/down arrows on a number input don’t trigger a change event unless the input is focused. You need to first click inside the field (to focus it) before using the arrows for the updated value to be registered when saving. I’ve added an improvement (onClick={(e) => e.currentTarget.focus()}) to ensure the input auto-focuses when clicked, so the behavior feels more intuitive.
Author
Owner

@oschwartz10612 commented on GitHub (Oct 19, 2025):

Thanks @Pallavikumarimdb appreciate the analysis!

<!-- gh-comment-id:3419186547 --> @oschwartz10612 commented on GitHub (Oct 19, 2025): Thanks @Pallavikumarimdb appreciate the analysis!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#8740