github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-07 21:30:36 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2825] [MERGED] fix(analytics): prevent countries from getting stuck highlighted on world map #7979

New Issue
Closed
opened 2026-04-25 16:31:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 16:31:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2825
Author: @AdnanSilajdzic
Created: 4/10/2026
Status: ✅ Merged
Merged: 4/11/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/worldmap-hover-stuck-public

📝 Commits (1)

  • 1aedf9d fix(worldmap): avoid stuck country hover state

📊 Changes

1 file changed (+17 additions, -7 deletions)

View changed files

📝 src/components/WorldMap.tsx (+17 -7)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

This fixes an issue on the analytics world map where hovered countries could remain highlighted after the cursor moved away.

I was able to reproduce this on the analytics page and traced it back to the hover implementation in WorldMap.tsx.

Before:

https://github.com/user-attachments/assets/268c63d3-9784-43e2-bde9-e8cfd4778e06

After applying this fix:

https://github.com/user-attachments/assets/e7a5ba94-2e49-4fe9-b019-dac927079dac

Cause

The previous implementation moved the hovered SVG country path to the end of the DOM during hover so it would render on top of neighboring countries.

That helped visually, but it also seems to interfere with hover cleanup in some cases, which can leave countries stuck in the highlighted state.

Fix

Instead of reordering the original country node during hover, this change renders the hovered country in a separate overlay path above the base map layer.

This keeps the hovered country visually on top while avoiding the sticky hover behavior.

How to test?

This can be tested by navigating to the /{orgId}/settings/logs/analytics and interacting with the map on the bottom of the screen.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2825 **Author:** [@AdnanSilajdzic](https://github.com/AdnanSilajdzic) **Created:** 4/10/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/worldmap-hover-stuck-public` --- ### 📝 Commits (1) - [`1aedf9d`](https://github.com/fosrl/pangolin/commit/1aedf9da0ac258e58735da61a26ab1dc00aa08d8) fix(worldmap): avoid stuck country hover state ### 📊 Changes **1 file changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/components/WorldMap.tsx` (+17 -7) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description This fixes an issue on the analytics world map where hovered countries could remain highlighted after the cursor moved away. I was able to reproduce this on the analytics page and traced it back to the hover implementation in `WorldMap.tsx`. Before: https://github.com/user-attachments/assets/268c63d3-9784-43e2-bde9-e8cfd4778e06 After applying this fix: https://github.com/user-attachments/assets/e7a5ba94-2e49-4fe9-b019-dac927079dac ## Cause The previous implementation moved the hovered SVG country path to the end of the DOM during hover so it would render on top of neighboring countries. That helped visually, but it also seems to interfere with hover cleanup in some cases, which can leave countries stuck in the highlighted state. ## Fix Instead of reordering the original country node during hover, this change renders the hovered country in a separate overlay path above the base map layer. This keeps the hovered country visually on top while avoiding the sticky hover behavior. ## How to test? This can be tested by navigating to the `/{orgId}/settings/logs/analytics` and interacting with the map on the bottom of the screen. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 16:31:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#7979
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?