github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 12:55:03 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2711] [CLOSED] fix: show informative message when saving with no targets #7924

New Issue
Closed
opened 2026-04-25 16:29:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 16:29:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2711
Author: @jaydeep-pipaliya
Created: 3/25/2026
Status: ❌ Closed

Base: main ← Head: fix/empty-targets-save-notification

📝 Commits (1)

  • 77314cd fix: show informative message when saving with no targets

📊 Changes

2 files changed (+10 additions, -0 deletions)

View changed files

📝 messages/en-US.json (+2 -0)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+8 -0)

📄 Description

Summary

  • When saving targets with an empty target list and no removals, the app previously showed a misleading "Settings updated" success notification
  • Now shows "No targets to save — Please add at least one target before saving" instead
  • Added translation keys targetNoTargets and targetNoTargetsDescription to en-US.json

Fixes #586

Test plan

  • Navigate to a resource's proxy settings
  • Without adding any targets, click "Save Targets"
  • Verify the toast says "No targets to save" instead of "Settings updated"
  • Add a target, save, and verify "Settings updated" still shows correctly
  • Remove all targets and save — verify deletions still process correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2711 **Author:** [@jaydeep-pipaliya](https://github.com/jaydeep-pipaliya) **Created:** 3/25/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/empty-targets-save-notification` --- ### 📝 Commits (1) - [`77314cd`](https://github.com/fosrl/pangolin/commit/77314cddfc797c5329b2bd7129d4a670f52c575c) fix: show informative message when saving with no targets ### 📊 Changes **2 files changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `messages/en-US.json` (+2 -0) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+8 -0) </details> ### 📄 Description ## Summary - When saving targets with an empty target list and no removals, the app previously showed a misleading "Settings updated" success notification - Now shows "No targets to save — Please add at least one target before saving" instead - Added translation keys `targetNoTargets` and `targetNoTargetsDescription` to `en-US.json` Fixes #586 ## Test plan - [ ] Navigate to a resource's proxy settings - [ ] Without adding any targets, click "Save Targets" - [ ] Verify the toast says "No targets to save" instead of "Settings updated" - [ ] Add a target, save, and verify "Settings updated" still shows correctly - [ ] Remove all targets and save — verify deletions still process correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 16:29:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#7924
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?