github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-07 05:09:18 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2522] [CLOSED] fix: logo URL validation shows cryptic error instead of meaningful message #7812

New Issue
Closed
opened 2026-04-25 16:26:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 16:26:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2522
Author: @shreyaspapi
Created: 2/23/2026
Status: ❌ Closed

Base: main ← Head: fix/2325-logo-url-validation

📝 Commits (1)

  • 0992ee4 fix: replace z.union with inline empty string check in logo URL validation

📊 Changes

2 files changed (+125 additions, -122 deletions)

View changed files

📝 server/private/routers/loginPage/upsertLoginPageBranding.ts (+68 -64)
📝 src/components/AuthPageBrandingForm.tsx (+57 -58)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Summary

Fixes #2325

  • Replaced z.union([z.literal(""), z.string().superRefine(...)]) with a single z.string().superRefine(...) that handles the empty string case internally
  • Applied the same fix to both client-side (AuthPageBrandingForm.tsx) and server-side (upsertLoginPageBranding.ts) validation schemas

Problem

When entering a logo URL that fails validation (e.g., the server doesn't return an image/* content-type), users see the cryptic error:

Too big: expected string to have <=0 characters

This happens because Zod's z.union tries all branches when one fails. The first branch (z.literal("")) expects an empty string, so its error message about <=0 characters gets surfaced instead of the actual validation error from the superRefine branch.

Fix

Move the empty string check inside the superRefine callback as an early return. This eliminates the z.union entirely, so validation errors (invalid URL, non-image content-type, network errors, etc.) are always reported directly to the user.

How to test?

All existing validation cases are preserved:

  • Empty string (no logo) -> passes
  • Invalid URL -> "Must be a valid URL"
  • URL returns non-200 -> "Failed to load image..."
  • URL doesn't serve image content-type -> "URL does not point to an image..."
  • Network/fetch error -> specific error message
  • Enterprise local path validation -> unchanged

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2522 **Author:** [@shreyaspapi](https://github.com/shreyaspapi) **Created:** 2/23/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/2325-logo-url-validation` --- ### 📝 Commits (1) - [`0992ee4`](https://github.com/fosrl/pangolin/commit/0992ee44fa7f40f61902a83c06f433743f80f121) fix: replace z.union with inline empty string check in logo URL validation ### 📊 Changes **2 files changed** (+125 additions, -122 deletions) <details> <summary>View changed files</summary> 📝 `server/private/routers/loginPage/upsertLoginPageBranding.ts` (+68 -64) 📝 `src/components/AuthPageBrandingForm.tsx` (+57 -58) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Summary Fixes #2325 - Replaced `z.union([z.literal(""), z.string().superRefine(...)])` with a single `z.string().superRefine(...)` that handles the empty string case internally - Applied the same fix to both client-side (`AuthPageBrandingForm.tsx`) and server-side (`upsertLoginPageBranding.ts`) validation schemas ## Problem When entering a logo URL that fails validation (e.g., the server doesn't return an `image/*` content-type), users see the cryptic error: > `Too big: expected string to have <=0 characters` This happens because Zod's `z.union` tries all branches when one fails. The first branch (`z.literal("")`) expects an empty string, so its error message about `<=0 characters` gets surfaced instead of the actual validation error from the `superRefine` branch. ## Fix Move the empty string check inside the `superRefine` callback as an early return. This eliminates the `z.union` entirely, so validation errors (invalid URL, non-image content-type, network errors, etc.) are always reported directly to the user. ## How to test? All existing validation cases are preserved: - Empty string (no logo) -> passes - Invalid URL -> `"Must be a valid URL"` - URL returns non-200 -> `"Failed to load image..."` - URL doesn't serve image content-type -> `"URL does not point to an image..."` - Network/fetch error -> specific error message - Enterprise local path validation -> unchanged --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 16:26:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#7812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?