github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[GH-ISSUE #2534] Session expiry deletes all resource sessions & HTTP cookie domain broken for non-SSL resources #6980

New Issue
Closed
opened 2026-04-25 15:58:06 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-25 15:58:06 -05:00
Owner
Copy Link

Originally created by @Abhinav-kodes on GitHub (Feb 25, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2534

Describe the Bug

While investigating the session logic (which likely contributes to issues like #2488), I found two critical bugs in server/auth/sessions/resource.ts that break session persistence:

Bug 1 — Session DELETE wipes entire resourceSessions table

File: server/auth/sessions/resource.ts
Function: validateResourceSessionToken

When a resource session is expired, the DELETE query uses a tautological WHERE clause: (Line - 90)

.where(eq(resourceSessions.sessionId, resourceSessions.sessionId))

This compares the column to itself, generating WHERE session_id = session_id (always true), which deletes ALL rows in the resourceSessions table, not just the expired one.
Every active session for every user on every resource is wiped whenever any single session expires.

Bug 2 — HTTP resource cookie set with broken Domain

File: server/auth/sessions/resource.ts
Function: serializeResourceSessionCookie

In the HTTP (non-SSL) path, the cookie string has a broken template literal: (Line - 184)

`... Path=/; Domain=$domain}`                           
//                   ^ missing opening brace — interpolation never happens

The browser receives Domain=$domain} as a literal string, rejects it, and never sends the cookie back — leaving HTTP resources perpetually unauthenticated.

Environment

  • OS Type & Version: Pop!_OS 22.04 LTS (Local Development Environment)
  • Pangolin Version: 1.15.4 (via dev branch Docker build)
  • Gerbil Version: 1.3.0
  • Traefik Version: 3.6.8
  • Newt Version: 1.9.0
  • Olm Version: N/A

To Reproduce

Bug 1: The Tautological Session Delete

  1. Authenticate and create at least two valid resource sessions in the database (e.g., log in as two different users, or access two different protected resources).
  2. Wait for one session to expire, then have that user make a request to the protected resource (triggering validateResourceSessionToken with the stale token).
  3. Query the resource_sessions database table.
  4. Observation: Notice that all sessions have been wiped from the table, logging everyone out, rather than just the single expired session.

Bug 2: The HTTP Cookie Domain Typo

  1. Configure a dummy resource to be served over standard HTTP (disable SSL).
  2. Attempt to authenticate to the resource via the web browser.
  3. Open the browser's Developer Tools -> Network tab and inspect the Set-Cookie response header.
  4. Observation: The domain attribute is literally set to Domain=$domain} instead of the parsed hostname (e.g., Domain=localhost). The browser subsequently rejects the cookie.

Expected Behavior

1. Session Deletion: When a single resource session reaches its expiration time, only that specific session's row should be deleted from the resourceSessions database table. All other valid user sessions across the platform should remain completely untouched and active.

2. HTTP Cookie Domain: When a user authenticates to a resource over standard HTTP, the Set-Cookie header should correctly interpolate the domain string (e.g., Domain=example.com or Domain=localhost). This ensures the browser properly accepts the cookie and maintains the user's authentication state for subsequent requests.

Originally created by @Abhinav-kodes on GitHub (Feb 25, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2534 ### Describe the Bug While investigating the session logic (which likely contributes to issues like #2488), I found two critical bugs in `server/auth/sessions/resource.ts` that break session persistence: ## Bug 1 — Session DELETE wipes entire resourceSessions table **File:** `server/auth/sessions/resource.ts` **Function:** `validateResourceSessionToken` When a resource session is expired, the DELETE query uses a tautological WHERE clause: (Line - 90) ```ts .where(eq(resourceSessions.sessionId, resourceSessions.sessionId)) ``` This compares the column to itself, generating WHERE session_id = session_id (always true), which deletes ALL rows in the resourceSessions table, not just the expired one. Every active session for every user on every resource is wiped whenever any single session expires. ## Bug 2 — HTTP resource cookie set with broken Domain **File:** ` server/auth/sessions/resource.ts` **Function:** `serializeResourceSessionCookie` In the HTTP (non-SSL) path, the cookie string has a broken template literal: (Line - 184) ```ts `... Path=/; Domain=$domain}` // ^ missing opening brace — interpolation never happens ``` The browser receives Domain=$domain} as a literal string, rejects it, and never sends the cookie back — leaving HTTP resources perpetually unauthenticated. ### Environment - **OS Type & Version:** Pop!_OS 22.04 LTS (Local Development Environment) - **Pangolin Version:** 1.15.4 (via `dev` branch Docker build) - **Gerbil Version:** 1.3.0 - **Traefik Version:** 3.6.8 - **Newt Version:** 1.9.0 - **Olm Version:** N/A ### To Reproduce **Bug 1: The Tautological Session Delete** 1. Authenticate and create at least two valid resource sessions in the database (e.g., log in as two different users, or access two different protected resources). 2. Wait for one session to expire, then have that user make a request to the protected resource (triggering `validateResourceSessionToken` with the stale token). 3. Query the `resource_sessions` database table. 4. **Observation:** Notice that *all* sessions have been wiped from the table, logging everyone out, rather than just the single expired session. **Bug 2: The HTTP Cookie Domain Typo** 1. Configure a dummy resource to be served over standard HTTP (disable SSL). 2. Attempt to authenticate to the resource via the web browser. 3. Open the browser's Developer Tools -> Network tab and inspect the `Set-Cookie` response header. 4. **Observation:** The domain attribute is literally set to `Domain=$domain}` instead of the parsed hostname (e.g., `Domain=localhost`). The browser subsequently rejects the cookie. ### Expected Behavior **1. Session Deletion:** When a single resource session reaches its expiration time, only that specific session's row should be deleted from the `resourceSessions` database table. All other valid user sessions across the platform should remain completely untouched and active. **2. HTTP Cookie Domain:** When a user authenticates to a resource over standard HTTP, the `Set-Cookie` header should correctly interpolate the domain string (e.g., `Domain=example.com` or `Domain=localhost`). This ensures the browser properly accepts the cookie and maintains the user's authentication state for subsequent requests.
GiteaMirror commented 2026-04-25 15:58:08 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Feb 25, 2026):

Thanks for fixing this!

<!-- gh-comment-id:3961567724 --> @oschwartz10612 commented on GitHub (Feb 25, 2026): Thanks for fixing this!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#6980
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?