github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 05:39:49 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2646] [MERGED] feat(installer): add default install directory with existing install … #5968

New Issue
Closed
opened 2026-04-23 02:54:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 02:54:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2646
Author: @LaurenceJJones
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/30/2026
Merged by: @oschwartz10612

Base: dev ← Head: feature/installer-default-dir

📝 Commits (1)

  • 47a99e3 feat(installer): add default install directory with existing install detection

📊 Changes

1 file changed (+119 additions, -0 deletions)

View changed files

📝 install/main.go (+119 -0)

📄 Description

…detection

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

  • Default to /opt/pangolin for new installations
  • Check current directory and /opt/pangolin for existing installs
  • Prompt to use existing install if found at default location
  • Offer to change directory ownership when running via sudo
  • Create installation directory if it doesn't exist

How to test?

Currently the installer generates files relative to where the installer is ran, ultimately this creates:

  • User confusion on where the files ended up
  • Documentation struggles since there is no "default directory" for user to follow if they want to make changes
  • User might generate in a folder and ask "How do I move this?"
  • Might cause user to accidentally place in a folder that has broad permissions and causes information exposure.

The intended direction of this PR is to standardize the output location so moving forward users can get a sense of where files will be generator and create a standard of where we would like them to be placed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2646 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/30/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `feature/installer-default-dir` --- ### 📝 Commits (1) - [`47a99e3`](https://github.com/fosrl/pangolin/commit/47a99e35ee2ecd82fb1ab2da655d36fd3301715a) feat(installer): add default install directory with existing install detection ### 📊 Changes **1 file changed** (+119 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `install/main.go` (+119 -0) </details> ### 📄 Description …detection ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description - Default to /opt/pangolin for new installations - Check current directory and /opt/pangolin for existing installs - Prompt to use existing install if found at default location - Offer to change directory ownership when running via sudo - Create installation directory if it doesn't exist ## How to test? Currently the installer generates files relative to where the installer is ran, ultimately this creates: - User confusion on where the files ended up - Documentation struggles since there is no "default directory" for user to follow if they want to make changes - User might generate in a folder and ask "How do I move this?" - Might cause user to accidentally place in a folder that has broad permissions and causes information exposure. The intended direction of this PR is to standardize the output location so moving forward users can get a sense of where files will be generator and create a standard of where we would like them to be placed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 02:54:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5968
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?