[PR #2121] [MERGED] feat: device approvals #5756

New Issue

Closed

opened 2026-04-23 02:46:30 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-23 02:46:30 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2121
Author: @Fredkiss3
Created: 12/18/2025
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @miloschwartz

Base: dev ← Head: feat/device-approvals

---

📝 Commits (10+)

• a5775a0 🗃️ create approvals table
• 009b86c Merge branch 'dev' into feat/device-approvals
• e983e11 🚧 wip: approval tables in DB
• 0f2b943 Merge branch 'dev' into feat/device-approvals
• 1f80845 🗃️ move approval state to client directly where it makes more sense
• cb21cab 🚧 add device approval in the roles page
• bbca200 🙈 do not include claude.md in gitignore
• abfe476 🚧 wip
• 39bebea ✨ create & update role with device approval
• 3ab25f5 ♻️ refactor

📊 Changes

39 files changed (+1545 additions, -280 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 messages/en-US.json (+31 -1)
📝 server/auth/actions.ts (+3 -1)
📝 server/db/pg/schema/privateSchema.ts (+36 -1)
📝 server/db/pg/schema/schema.ts (+6 -2)
📝 server/db/sqlite/schema/privateSchema.ts (+26 -1)
📝 server/db/sqlite/schema/schema.ts (+11 -3)
📝 server/lib/calculateUserClientsForOrgs.ts (+48 -18)
➕ server/private/routers/approvals/index.ts (+15 -0)
➕ server/private/routers/approvals/listApprovals.ts (+188 -0)
➕ server/private/routers/approvals/processPendingApproval.ts (+142 -0)
📝 server/private/routers/external.ts (+19 -0)
📝 server/private/routers/loginPage/getLoginPageBranding.ts (+3 -5)
📝 server/routers/client/blockClient.ts (+1 -1)
📝 server/routers/client/listClients.ts (+1 -0)
📝 server/routers/client/unblockClient.ts (+1 -1)
📝 server/routers/external.ts (+8 -0)
📝 server/routers/integration.ts (+8 -0)
📝 server/routers/role/createRole.ts (+9 -1)
📝 server/routers/role/listRoles.ts (+8 -9)

...and 19 more files

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Summary

Main changes:

• Approvals for user added devices, only for roles which require approvals.

Demo

https://github.com/user-attachments/assets/e8776a0a-c98b-418d-a81f-176df428f9d5

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2121 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `feat/device-approvals` --- ### 📝 Commits (10+) - [`a5775a0`](https://github.com/fosrl/pangolin/commit/a5775a0f4ffa486d8a1262987da7d941ee8e1e80) 🗃️ create `approvals` table - [`009b86c`](https://github.com/fosrl/pangolin/commit/009b86c33b95f2316cf24fb14073cca4a08448ff) Merge branch 'dev' into feat/device-approvals - [`e983e11`](https://github.com/fosrl/pangolin/commit/e983e1166afc5da7e992dce22a3aea0d28206ce5) 🚧 wip: approval tables in DB - [`0f2b943`](https://github.com/fosrl/pangolin/commit/0f2b94307f5351aa72cd797197cbb88c579700fb) Merge branch 'dev' into feat/device-approvals - [`1f80845`](https://github.com/fosrl/pangolin/commit/1f80845a7a2f0a87c015be64a50a311671a15ba9) 🗃️ move approval state to client directly where it makes more sense - [`cb21cab`](https://github.com/fosrl/pangolin/commit/cb21cab117c2272931285f8b71a49143676851b1) 🚧 add device approval in the roles page - [`bbca200`](https://github.com/fosrl/pangolin/commit/bbca200ceb0003113b1e2b52f1917745615cefa9) 🙈 do not include claude.md in gitignore - [`abfe476`](https://github.com/fosrl/pangolin/commit/abfe476cb9f7710f41d0a6be139d6b0a03590d0e) 🚧 wip - [`39bebea`](https://github.com/fosrl/pangolin/commit/39bebea5f77e01f5a7e3d2af2b0d7f9aa014a71c) ✨ create & update role with device approval - [`3ab25f5`](https://github.com/fosrl/pangolin/commit/3ab25f5ff15338fe96a84dae7cc66722366364d0) ♻️ refactor ### 📊 Changes **39 files changed** (+1545 additions, -280 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `messages/en-US.json` (+31 -1) 📝 `server/auth/actions.ts` (+3 -1) 📝 `server/db/pg/schema/privateSchema.ts` (+36 -1) 📝 `server/db/pg/schema/schema.ts` (+6 -2) 📝 `server/db/sqlite/schema/privateSchema.ts` (+26 -1) 📝 `server/db/sqlite/schema/schema.ts` (+11 -3) 📝 `server/lib/calculateUserClientsForOrgs.ts` (+48 -18) ➕ `server/private/routers/approvals/index.ts` (+15 -0) ➕ `server/private/routers/approvals/listApprovals.ts` (+188 -0) ➕ `server/private/routers/approvals/processPendingApproval.ts` (+142 -0) 📝 `server/private/routers/external.ts` (+19 -0) 📝 `server/private/routers/loginPage/getLoginPageBranding.ts` (+3 -5) 📝 `server/routers/client/blockClient.ts` (+1 -1) 📝 `server/routers/client/listClients.ts` (+1 -0) 📝 `server/routers/client/unblockClient.ts` (+1 -1) 📝 `server/routers/external.ts` (+8 -0) 📝 `server/routers/integration.ts` (+8 -0) 📝 `server/routers/role/createRole.ts` (+9 -1) 📝 `server/routers/role/listRoles.ts` (+8 -9) _...and 19 more files_ </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Summary **Main changes**: - Approvals for user added devices, only for roles which require approvals. ## Demo https://github.com/user-attachments/assets/e8776a0a-c98b-418d-a81f-176df428f9d5 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-23 02:46:30 -05:00

GiteaMirror closed this issue 2026-04-23 02:46:31 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

resource-policies

copilot/fix-create-alert-visibility

dev

dependabot/npm_and_yarn/prod-patch-updates-64dd675a88

dependabot/npm_and_yarn/dev-minor-updates-10ef4f0f15

redis

crowdin_dev

newt-install-commands

dependabot/npm_and_yarn/multi-d2fd79378c

dependabot/npm_and_yarn/uuid-14.0.0

dependabot/npm_and_yarn/postcss-8.5.10

miloschwartz-patch-2

dependabot/github_actions/actions/setup-node-6.4.0

dependabot/npm_and_yarn/next-16.2.1

dependabot/npm_and_yarn/recharts-3.8.1

dependabot/npm_and_yarn/next-intl-4.9.1

cross-org-idp

update-readme

miloschwartz-patch-1

breakout-sites-tables

revert-2766-feature/systemd-install-instructions

dependabot/docker/docker/library/node-25-slim

ssh

delete-account

msg-delivery

org-only-idp

cicd

patch

site-targets-auto-login

1.18.2-s.5

1.18.2-s.4

1.18.2-s.3

1.18.2-s.2

1.18.2-s.1

1.18.2

1.18.2-s.0

1.18.1-s.7

1.18.1-s.6

1.18.1-s.5

1.18.1-s.4

1.18.1-s.3

1.18.1-s.2

1.18.1

1.18.1-s.1

1.18.1-s.0

1.18.0-s.2

1.18.0-s.1

1.18.0

1.18.0-s.0

1.17.1-s.7

1.17.1-s.6

1.18.0-rc.0

1.17.1-s.5

1.17.1-s.4

1.17.1-s.3

1.17.1

1.17.1-s.2

1.17.1-s.1

1.17.1-s.0

1.17.0-s.4

1.17.0

1.17.0-s.3

1.17.0-s.2

1.17.0-s.1

1.17.0-s.0

1.17.0-rc.0

1.16.2-s.22

1.16.2-s.21

1.16.2-s.20

1.16.2-s.19

1.16.2-s.18

1.16.2-s.17

1.16.2-s.16

1.16.2-s.15

1.16.2-s.14

1.16.2-s.13

1.16.2-s.12

1.16.2-s.11

1.16.2-s.10

1.16.2-s.9

1.16.2-s.8

1.16.2-s.7

1.16.2-s.6

1.16.2-s.5

1.16.2-s.4

1.16.2-s.3

1.16.2-s.2

1.16.2-s.1

1.16.2

1.16.2-s.0

1.16.1-s.1

1.16.1

1.16.1-s.0

1.16.0

1.16.0-s.1

1.16.0-s.0

1.16.0-rc.0

1.15.4-s.10

1.15.4-s.9

1.15.4-s.8

1.15.4-s.7

1.15.4-s.6

1.15.4-s.5

1.15.4-s.4

1.15.4-s.3

1.15.4-s.2

1.15.4-s.1

1.15.4

1.15.4-s.0

1.15.3

1.15.3-s.1

1.15.3-s.0

1.15.2

1.15.1-s.1

1.15.1-s.0

1.15.1

1.15.0-s.5

1.15.0

1.15.0-s.4

1.15.0-s.3

1.15.0-s.2

1.15.0-s.1

1.15.0-s.0

1.15.0-rc.0

1.14.1-s.3

1.14.1-s.2

1.14.1-s.1

1.14.1-s.0

1.14.1

1.14.0-s.2

1.14.0

1.14.0-rc.0

1.13.1

1.13.1-s.0

1.13.0

1.13.0.s.0

1.13.0-rc.0

1.12.2-s.5

1.12.3

1.12.2-s.4

1.12.2-s.3

1.12.2-s.2

1.12.2-s.1

1.12.2

1.12.2-s.0

1.12.1

1.12.0

1.12.0-s.0

1.12.0-rc.0

1.11.1

1.11.1-s.0

1.11.0-s.5

1.11.0

1.11.0-s.4

1.11.0-s.3

1.11.0-s.2

1.11.0-s.1

1.11.0-s.0

1.10.3

1.10.2

1.10.1

1.10.0

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.0

1.7.3

1.7.2

1.7.1

1.7.0

1.6.2

1.6.1

1.6.0

1.5.1

1.5.0

1.4.0

1.3.2

1.3.1

1.3.0

1.2.0

1.1.0

1.0.1

1.0.0

1.0.0-beta.15

1.0.0-beta.14

1.0.0-beta.13

1.0.0-beta.12

1.0.0-beta.11

1.0.0-beta.10

1.0.0-beta.9

1.0.0-beta.8

1.0.0-beta.7

1.0.0-beta.6

1.0.0-beta.5

1.0.0-beta.4

1.0.0-beta.3

1.0.0-beta.2

1.0.0-beta.1

Labels

Clear labels

api

authentication

bug

config

dependencies

docker

documentation

enhancement

good first issue

help wanted

Improvement

Look Into

needs investigating

networking

new feature

non-critical bug

potential bug

pull-request

Mirrored from GitHub Pull Request

question

reverse proxy

Security

stale

ui

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/pangolin#5756