github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 20:59:07 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #1177] [MERGED] Portbinding fixes #5353

New Issue
Closed
opened 2026-04-23 02:30:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 02:30:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1177
Author: @Error-Gap
Created: 7/31/2025
Status: ✅ Merged
Merged: 8/3/2025
Merged by: @oschwartz10612

Base: dev ← Head: portbinding-fixes

📝 Commits (3)

  • 1a4d34a Merge pull request #1172 from fosrl/dev
  • 69b28b9 Merge branch 'dev'
  • 481714f Fix for issues with binding ports other than 80/443

📊 Changes

3 files changed (+17 additions, -7 deletions)

View changed files

📝 server/routers/badger/exchangeSession.ts (+8 -2)
📝 server/routers/badger/verifySession.ts (+4 -5)
📝 src/app/auth/resource/[resourceId]/page.tsx (+5 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

server/routers/badger/verifySession.ts : verifyResourceSession() updated code behind "cleanHost" var to a regex which strips the trailing :port for any port (rather than a string match for 80/443)
src/app/auth/resource/[resourceId]/page.tsx : ResourceAuthPage() added a secondary match for serverResourceHost and redirectHost that accounts for ports
server/routers/badger/exchangeSession.ts : Updated exchangeSession() to use the same "cleanHost" type var (with port-stripping) as in verifyResourceSession(), replaced references to "host" with "cleanHost"

How to test?

When running from docker, bind the ports in docker-compose with something other than 443:443 and 80:80
(in my case I also changed the "entrypoints" ports for traefik but this may not be necessary)

Fixes #1133
Fixes #1142

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1177 **Author:** [@Error-Gap](https://github.com/Error-Gap) **Created:** 7/31/2025 **Status:** ✅ Merged **Merged:** 8/3/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `portbinding-fixes` --- ### 📝 Commits (3) - [`1a4d34a`](https://github.com/fosrl/pangolin/commit/1a4d34a8020b67a07f553fe21947f96c200dbbf9) Merge pull request #1172 from fosrl/dev - [`69b28b9`](https://github.com/fosrl/pangolin/commit/69b28b9b02f67b5dbdd004dafdfcb0ebe331655a) Merge branch 'dev' - [`481714f`](https://github.com/fosrl/pangolin/commit/481714f095d2e8a4a1e34207bb3569194bcc3538) Fix for issues with binding ports other than 80/443 ### 📊 Changes **3 files changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/badger/exchangeSession.ts` (+8 -2) 📝 `server/routers/badger/verifySession.ts` (+4 -5) 📝 `src/app/auth/resource/[resourceId]/page.tsx` (+5 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description server/routers/badger/verifySession.ts : verifyResourceSession() updated code behind "cleanHost" var to a regex which strips the trailing :port for any port (rather than a string match for 80/443) src/app/auth/resource/[resourceId]/page.tsx : ResourceAuthPage() added a secondary match for serverResourceHost and redirectHost that accounts for ports server/routers/badger/exchangeSession.ts : Updated exchangeSession() to use the same "cleanHost" type var (with port-stripping) as in verifyResourceSession(), replaced references to "host" with "cleanHost" ## How to test? When running from docker, bind the ports in docker-compose with something other than 443:443 and 80:80 (in my case I also changed the "entrypoints" ports for traefik but this may not be necessary) Fixes #1133 Fixes #1142 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 02:30:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5353
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?