github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-22 09:32:36 -05:00
Code Issues 959 Packages Projects Releases 74 Wiki Activity

[PR #501] [MERGED] Add option to customise TLS server name in resource settings #5189

New Issue
Closed
opened 2026-04-23 02:25:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 02:25:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/501
Author: @achtnullzwei
Created: 4/9/2025
Status: ✅ Merged
Merged: 4/20/2025
Merged by: @miloschwartz

Base: dev ← Head: customize-tls-server-name

📝 Commits (4)

  • 674316a add option to set TLS Server Name
  • 517bc7f added table change to new migration script
  • 64a2cc2 adjusting field description; fix migration script; trying to resolve conflict in updateResource.ts
  • 25c125b added advanced section to general page & custom host header field

📊 Changes

8 files changed (+267 additions, -7 deletions)

View changed files

📝 server/db/schemas/schema.ts (+3 -1)
📝 server/lib/schemas.ts (+7 -0)
📝 server/routers/resource/listResources.ts (+6 -2)
📝 server/routers/resource/updateResource.ts (+22 -1)
📝 server/routers/traefik/getTraefikConfig.ts (+42 -1)
📝 server/setup/migrations.ts (+3 -1)
➕ server/setup/scripts/1.3.0.ts (+26 -0)
📝 src/app/[orgId]/settings/resources/[resourceId]/general/page.tsx (+158 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Added an option to set a custom TLS Server Name to solve the issue with strict SNI checks. I have added it to the "General" page in Resource settings. Couldn't rly think of a better place, and didn't want to create a new section for it. Also it doesn't make sense to set this on target level. Happy to adjust if needed.

Usage:

  • In general page of the resource settings, add the desired domain name to the new field TLS Server Name. Save.
  • To remove it, simply empty the field and save again.
  • Value entered is checked against meaningful entries.

Value is stored in the resource table in a new column names tlsServerName. Hence, this would require to be covered in the migration scripts. I added a draft migration for future version 1.3.0 as a suggestion.

Screenshot:

432051205-ae8a5dea-bde4-4ffd-9f3f-b989e59af1e5

Notes:
This is my very first contribution to any project on Github. I usually just work on my own project, but I felt I would like to contribute and get this feature implemented. In any case, I am kindly asking for some patience, if I did sth wrong. I am not rly used to write TS, but it was a lot of fun trying to understand the language a bit more, the code you created and add a feature to it. With respect to the pull request, I saw in the contribution guidelines, that contributions are supposed to be added to main branch. However, my changes would probably break without altering the database and having migration scripts properly added. I added a draft for that at least. Furthermore, I saw some recent pull requests made against dev branch. I hope that's ok. Otherwise, I can change it to the main branch.

How to test?

Build from sources and use docker image. I did test this as extensively as I could and can validate it works, at least in my homelab. I did test it on a live VPS with whoami containers and multiple levels of cascaded reverse-proxies. Also checked for UI issues as much as I can.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/501 **Author:** [@achtnullzwei](https://github.com/achtnullzwei) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/20/2025 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `customize-tls-server-name` --- ### 📝 Commits (4) - [`674316a`](https://github.com/fosrl/pangolin/commit/674316aa46014179e358cc39a9dc6b7cb81e7cb6) add option to set TLS Server Name - [`517bc7f`](https://github.com/fosrl/pangolin/commit/517bc7f6325436ef443757dcc87de7b967e5bd31) added table change to new migration script - [`64a2cc2`](https://github.com/fosrl/pangolin/commit/64a2cc23c6629616ae968f07fdbbf05d8e04b926) adjusting field description; fix migration script; trying to resolve conflict in updateResource.ts - [`25c125b`](https://github.com/fosrl/pangolin/commit/25c125b96d84b6278882c957a63f8e569899d24a) added advanced section to general page & custom host header field ### 📊 Changes **8 files changed** (+267 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/db/schemas/schema.ts` (+3 -1) 📝 `server/lib/schemas.ts` (+7 -0) 📝 `server/routers/resource/listResources.ts` (+6 -2) 📝 `server/routers/resource/updateResource.ts` (+22 -1) 📝 `server/routers/traefik/getTraefikConfig.ts` (+42 -1) 📝 `server/setup/migrations.ts` (+3 -1) ➕ `server/setup/scripts/1.3.0.ts` (+26 -0) 📝 `src/app/[orgId]/settings/resources/[resourceId]/general/page.tsx` (+158 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Added an option to set a custom TLS Server Name to solve the issue with strict SNI checks. I have added it to the "General" page in Resource settings. Couldn't rly think of a better place, and didn't want to create a new section for it. Also it doesn't make sense to set this on target level. Happy to adjust if needed. Usage: - In general page of the resource settings, add the desired domain name to the new field TLS Server Name. Save. - To remove it, simply empty the field and save again. - Value entered is checked against meaningful entries. Value is stored in the resource table in a new column names tlsServerName. Hence, this would require to be covered in the migration scripts. I added a draft migration for future version 1.3.0 as a suggestion. Screenshot: ![432051205-ae8a5dea-bde4-4ffd-9f3f-b989e59af1e5](https://github.com/user-attachments/assets/9fed0a97-9b55-4aca-bb85-69091881b9dc) Notes: This is my very first contribution to any project on Github. I usually just work on my own project, but I felt I would like to contribute and get this feature implemented. In any case, I am kindly asking for some patience, if I did sth wrong. I am not rly used to write TS, but it was a lot of fun trying to understand the language a bit more, the code you created and add a feature to it. With respect to the pull request, I saw in the contribution guidelines, that contributions are supposed to be added to main branch. However, my changes would probably break without altering the database and having migration scripts properly added. I added a draft for that at least. Furthermore, I saw some recent pull requests made against dev branch. I hope that's ok. Otherwise, I can change it to the main branch. ## How to test? Build from sources and use docker image. I did test this as extensively as I could and can validate it works, at least in my homelab. I did test it on a live VPS with whoami containers and multiple levels of cascaded reverse-proxies. Also checked for UI issues as much as I can. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 02:25:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5189
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?