github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-21 01:11:38 -05:00
Code Issues 856 Packages Projects Releases 74 Wiki Activity

[PR #2841] [MERGED] fix(worldmap): correct topojson feature typing #5125

New Issue
Closed
opened 2026-04-20 09:16:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:16:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2841
Author: @AdnanSilajdzic
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/worldmap-typescript-followup

📝 Commits (1)

  • 0cb04d0 fix(worldmap): correct topojson feature typing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/components/WorldMap.tsx (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Summary

This is a small follow-up to my previously merged world map hover fix: #2825.

That earlier change fixed the stuck hover state on the analytics map, but it also introduced a TypeScript error. This PR corrects that typing so the fix passes TypeScript cleanly as well.

There is no intended behavior change here. This is just a typing fix for the already-merged hover-state change that I should have included in the original PR. Sorry about that.

How to test?

npm run dev:check

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2841 **Author:** [@AdnanSilajdzic](https://github.com/AdnanSilajdzic) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/worldmap-typescript-followup` --- ### 📝 Commits (1) - [`0cb04d0`](https://github.com/fosrl/pangolin/commit/0cb04d02905325533c3eba7d4e15b9c60940017b) fix(worldmap): correct topojson feature typing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/components/WorldMap.tsx` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Summary This is a small follow-up to my previously merged world map hover fix: [#2825](https://github.com/fosrl/pangolin/pull/2825). That earlier change fixed the stuck hover state on the analytics map, but it also introduced a TypeScript error. This PR corrects that typing so the fix passes TypeScript cleanly as well. There is no intended behavior change here. This is just a typing fix for the already-merged hover-state change that I should have included in the original PR. Sorry about that. ## How to test? `npm run dev:check` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:16:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5125
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?