github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 21:59:09 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2626] [MERGED] fix: Credenza dialog max-height overflow hiding footer buttons #2572 #5011

New Issue
Closed
opened 2026-04-20 09:14:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:14:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2626
Author: @shreyaspapi
Created: 3/10/2026
Status: ✅ Merged
Merged: 3/10/2026
Merged by: @oschwartz10612

Base: main ← Head: fix/2572-healthcheck-button-hidden

📝 Commits (1)

  • bae952f fix: ensure Credenza dialog max-height

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/components/Credenza.tsx (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Fixes #2572

The CredenzaContent component on desktop used max-h-screen (100vh) but was positioned with top: clamp(1.5rem, 12vh, 200px). This caused the dialog to extend up to 200px below the viewport, hiding the footer and its "Done" button behind the OS taskbar.

Changed md:max-h-screen to md:max-h-[calc(100vh-clamp(3rem,24vh,400px))] so the max-height subtracts the top offset (doubled to reserve equal space at top and bottom), keeping the dialog fully within the viewport.

How to test?

  1. Open any resource and navigate to Proxy tab
  2. Click the healthcheck icon on a target to open the HealthCheck dialog
  3. Toggle healthcheck Enabled to expand all form fields
  4. Verify the "Done" button is visible at 100% zoom without needing to scroll the page
  5. Zoom in/out — the dialog should stay within the viewport and scroll internally

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2626 **Author:** [@shreyaspapi](https://github.com/shreyaspapi) **Created:** 3/10/2026 **Status:** ✅ Merged **Merged:** 3/10/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `fix/2572-healthcheck-button-hidden` --- ### 📝 Commits (1) - [`bae952f`](https://github.com/fosrl/pangolin/commit/bae952fccecc91d3312ceaaf9540ad5eb8dc12fb) fix: ensure Credenza dialog max-height ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/components/Credenza.tsx` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Fixes #2572 The `CredenzaContent` component on desktop used `max-h-screen` (100vh) but was positioned with `top: clamp(1.5rem, 12vh, 200px)`. This caused the dialog to extend up to 200px below the viewport, hiding the footer and its "Done" button behind the OS taskbar. Changed `md:max-h-screen` to `md:max-h-[calc(100vh-clamp(3rem,24vh,400px))]` so the max-height subtracts the top offset (doubled to reserve equal space at top and bottom), keeping the dialog fully within the viewport. ## How to test? 1. Open any resource and navigate to **Proxy** tab 2. Click the healthcheck icon on a target to open the HealthCheck dialog 3. Toggle healthcheck **Enabled** to expand all form fields 4. Verify the **"Done" button** is visible at 100% zoom without needing to scroll the page 5. Zoom in/out — the dialog should stay within the viewport and scroll internally --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:14:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5011
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?