github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-06 00:22:42 -05:00
Code Issues 464 Packages Projects Releases 71 Wiki Activity

[PR #2618] Skip invalid Docker resources instead of failing entire blueprint (#1784) #5005

New Issue
Open
opened 2026-04-20 09:13:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:13:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2618
Author: @LunarECL
Created: 3/8/2026
Status: 🔄 Open

Base: dev ← Head: fix-docker-label-partial-validation

📝 Commits (1)

  • 90d6178 Skip invalid Docker resources instead of failing entire blueprint (#1784)

📊 Changes

1 file changed (+72 additions, -7 deletions)

View changed files

📝 server/lib/blueprints/applyNewtDockerBlueprint.ts (+72 -7)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Fixes #1784

If one Docker container had bad labels (like missing a port on a container with no EXPOSE), it would block every other container from updating too. Not great.

Now there's a per-resource pre-validation step in applyNewtDockerBlueprint.ts that catches invalid resources and filters them out before they hit applyBlueprint(). Valid ones still go through the normal ConfigSchema validation, so cross-resource checks like domain/port/alias uniqueness work the same as before. Invalid ones just get logged with the Zod error path and skipped.

Only touched server/lib/blueprints/applyNewtDockerBlueprint.ts. Everything else (applyBlueprint.ts, types.ts, parseDockerContainers.ts) is unchanged.

How to test?

  1. Set up two Docker services with Pangolin labels on the same Docker socket
  2. Remove the port label from one service that has no EXPOSE directive
  3. Update a label on the other (valid) service
  4. Before fix: Both services fail to update. Log shows Validation error: Required at "proxy-resources.testservice.targets[0].port"
  5. After fix: Valid service updates normally. Invalid service gets skipped with a warning: Skipping invalid Docker proxy-resources "testservice": targets.0.port: RequiredRequired`

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2618 **Author:** [@LunarECL](https://github.com/LunarECL) **Created:** 3/8/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `fix-docker-label-partial-validation` --- ### 📝 Commits (1) - [`90d6178`](https://github.com/fosrl/pangolin/commit/90d6178a0b8d84a9b54ffacbf7cb3c48a87b3631) Skip invalid Docker resources instead of failing entire blueprint (#1784) ### 📊 Changes **1 file changed** (+72 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `server/lib/blueprints/applyNewtDockerBlueprint.ts` (+72 -7) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Fixes #1784 If one Docker container had bad labels (like missing a port on a container with no EXPOSE), it would block every other container from updating too. Not great. Now there's a per-resource pre-validation step in `applyNewtDockerBlueprint.ts` that catches invalid resources and filters them out before they hit `applyBlueprint()`. Valid ones still go through the normal `ConfigSchema` validation, so cross-resource checks like domain/port/alias uniqueness work the same as before. Invalid ones just get logged with the Zod error path and skipped. Only touched `server/lib/blueprints/applyNewtDockerBlueprint.ts`. Everything else (`applyBlueprint.ts`, `types.ts`, `parseDockerContainers.ts`) is unchanged. ## How to test? 1. Set up two Docker services with Pangolin labels on the same Docker socket 2. Remove the `port` label from one service that has no `EXPOSE` directive 3. Update a label on the other (valid) service 4. **Before fix:** Both services fail to update. Log shows `Validation error: Required at "proxy-resources.testservice.targets[0].port"` 5. **After fix:** Valid service updates normally. Invalid service gets skipped with a warning: `Skipping invalid Docker proxy-resources "testservice": targets.0.port: Required`Required` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:13:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#5005
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?