github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 13:49:15 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2493] [CLOSED] feat(resources): add redirect domain management in settings #4935

New Issue
Closed
opened 2026-04-20 09:12:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:12:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2493
Author: @LaurenceJJones
Created: 2/17/2026
Status: ❌ Closed

Base: dev ← Head: feat/resource-domain-redirect

📝 Commits (2)

  • e81ce50 Add multi-domain redirect support for public resources
  • d9d7e7b feat(resources): add redirect domain management in resource settings

📊 Changes

12 files changed (+572 additions, -50 deletions)

View changed files

📝 server/db/pg/schema/schema.ts (+2 -1)
📝 server/db/sqlite/schema/schema.ts (+2 -1)
📝 server/lib/traefik/getTraefikConfig.ts (+74 -0)
📝 server/private/lib/traefik/getTraefikConfig.ts (+74 -0)
📝 server/routers/resource/createResource.ts (+19 -3)
📝 server/routers/resource/getResource.ts (+22 -4)
📝 server/routers/resource/updateResource.ts (+33 -2)
📝 server/setup/migrationsPg.ts (+3 -1)
📝 server/setup/migrationsSqlite.ts (+3 -1)
➕ server/setup/scriptsPg/1.15.5.ts (+24 -0)
➕ server/setup/scriptsSqlite/1.15.5.ts (+27 -0)
📝 src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx (+289 -37)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

I’m not sure of the best migration approach here, since this feature requires adding a new column to the resources table so its bundle inside of the PR, but maintainers may want to change it to a minor version since its a new feature?

however, there may be another option which we create a dedicate table for this? 🤷🏻

  • add redirect domains section in resource settings
  • add "Add Redirect" flow using DomainPicker
  • validate redirect domains to prevent primary-domain and duplicate entries
  • normalize redirect domains before save (ASCII/lowercase)
  • support removing redirect domains from the configured list
  • add translation-key fallbacks for new redirect copy

How to test?

When editing a resource, under the general tab you now have "Redirect" options which allow you to set subdomains or another domain (that added in the system) to redirect to the currently edited resource. This is useful as users may host a website on the base domain and requests to www. should be redirected to the base domain on a permanent redirect (or the reverse depending on the user preference).

image

Before scaffolding this feature the only option would be to create another resource that take the subdomain and points to the same target, however, that is not scalable and creates duplicate records.

Open to comments/feedback on the PR as direction may have to change or may prompt new ideas on how to achieve this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2493 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 2/17/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/resource-domain-redirect` --- ### 📝 Commits (2) - [`e81ce50`](https://github.com/fosrl/pangolin/commit/e81ce507232095a70e679fcb31820d1116df1285) Add multi-domain redirect support for public resources - [`d9d7e7b`](https://github.com/fosrl/pangolin/commit/d9d7e7b7b34193e3c80e02ac46c2aefec5f392da) feat(resources): add redirect domain management in resource settings ### 📊 Changes **12 files changed** (+572 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `server/db/pg/schema/schema.ts` (+2 -1) 📝 `server/db/sqlite/schema/schema.ts` (+2 -1) 📝 `server/lib/traefik/getTraefikConfig.ts` (+74 -0) 📝 `server/private/lib/traefik/getTraefikConfig.ts` (+74 -0) 📝 `server/routers/resource/createResource.ts` (+19 -3) 📝 `server/routers/resource/getResource.ts` (+22 -4) 📝 `server/routers/resource/updateResource.ts` (+33 -2) 📝 `server/setup/migrationsPg.ts` (+3 -1) 📝 `server/setup/migrationsSqlite.ts` (+3 -1) ➕ `server/setup/scriptsPg/1.15.5.ts` (+24 -0) ➕ `server/setup/scriptsSqlite/1.15.5.ts` (+27 -0) 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx` (+289 -37) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description I’m not sure of the best migration approach here, since this feature requires adding a new column to the resources table so its bundle inside of the PR, but maintainers may want to change it to a minor version since its a new feature? however, there may be another option which we create a dedicate table for this? 🤷🏻 - add redirect domains section in resource settings - add "Add Redirect" flow using DomainPicker - validate redirect domains to prevent primary-domain and duplicate entries - normalize redirect domains before save (ASCII/lowercase) - support removing redirect domains from the configured list - add translation-key fallbacks for new redirect copy ## How to test? When editing a resource, under the general tab you now have "Redirect" options which allow you to set subdomains or another domain (that added in the system) to redirect to the currently edited resource. This is useful as users may host a website on the base domain and requests to `www.` should be redirected to the base domain on a permanent redirect (or the reverse depending on the user preference). <img width="1767" height="711" alt="image" src="https://github.com/user-attachments/assets/8108555e-079d-465c-84e9-2b58eeaa54af" /> Before scaffolding this feature the only option would be to create another resource that take the subdomain and points to the same target, however, that is not scalable and creates duplicate records. Open to comments/feedback on the PR as direction may have to change or may prompt new ideas on how to achieve this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:12:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?