github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-07 21:30:36 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #2306] [MERGED] fix: tab between host & port in resource target address column #4879

New Issue
Closed
opened 2026-04-20 09:10:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:10:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2306
Author: @Fredkiss3
Created: 1/23/2026
Status: ✅ Merged
Merged: 1/23/2026
Merged by: @miloschwartz

Base: dev ← Head: fix/tab-from-host-port

📝 Commits (2)

  • e3e4bdf 🚸 fix target item tabbing by memoizing the getColumns (and its dependencies)
  • c1b4732 🔥 remove useless useEffect

📊 Changes

6 files changed (+439 additions, -758 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx (+49 -267)
📝 src/app/[orgId]/settings/resources/proxy/create/page.tsx (+143 -475)
📝 src/components/DomainPicker.tsx (+0 -12)
➕ src/components/resource-target-address-item.tsx (+241 -0)
📝 src/components/ui/input.tsx (+1 -1)
📝 src/components/ui/select.tsx (+5 -3)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Summary

  • Fix tabulation between host and port inputs in target address in resources by memoizing the getColumns function and all its dependencies
  • Refactored the target address component into its own component
  • Also fixed the focus state of the components in the target address to have the same visual state

Screenshots

Before After

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2306 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 1/23/2026 **Status:** ✅ Merged **Merged:** 1/23/2026 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `fix/tab-from-host-port` --- ### 📝 Commits (2) - [`e3e4bdf`](https://github.com/fosrl/pangolin/commit/e3e4bdfe09a90cfd829fec0e25382fb28c6d849c) 🚸 fix target item tabbing by memoizing the `getColumns` (and its dependencies) - [`c1b4732`](https://github.com/fosrl/pangolin/commit/c1b473294e5738ea827e47b68a09c0dc09eebe52) 🔥 remove useless `useEffect` ### 📊 Changes **6 files changed** (+439 additions, -758 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/proxy/page.tsx` (+49 -267) 📝 `src/app/[orgId]/settings/resources/proxy/create/page.tsx` (+143 -475) 📝 `src/components/DomainPicker.tsx` (+0 -12) ➕ `src/components/resource-target-address-item.tsx` (+241 -0) 📝 `src/components/ui/input.tsx` (+1 -1) 📝 `src/components/ui/select.tsx` (+5 -3) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Summary - Fix tabulation between host and port inputs in target address in resources by memoizing the `getColumns` function and all its dependencies - Refactored the target address component into its own component - Also fixed the focus state of the components in the target address to have the same visual state ## Screenshots | Before | After | | :----------------: | :--------: | | <video src="https://github.com/user-attachments/assets/a7acc694-51ad-4a28-88bf-ce8623d6f084"></video> | <video src="https://github.com/user-attachments/assets/51b3ad48-03d6-4731-8abc-b3fbb14aadcf"></video> | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:10:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?