github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-08 21:59:09 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[PR #1971] [MERGED] feat(healthcheck): add SNI support for target healthchecks #4732

New Issue
Closed
opened 2026-04-20 09:03:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 09:03:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/1971
Author: @water-sucks
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @oschwartz10612

Base: dev ← Head: add-tls-server-name-to-health-check-fields

📝 Commits (2)

  • f33be14 feat(schema): add TLS server name column to target healthcheck tables
  • ca9273c feat(healthcheck): add SNI input field to target healthcheck config

📊 Changes

11 files changed (+72 additions, -15 deletions)

View changed files

📝 messages/en-US.json (+2 -0)
📝 server/db/pg/schema/schema.ts (+2 -1)
📝 server/db/sqlite/schema/schema.ts (+2 -1)
📝 server/routers/newt/handleNewtRegisterMessage.ts (+4 -2)
📝 server/routers/newt/targets.ts (+2 -1)
📝 server/routers/target/createTarget.ts (+3 -1)
📝 server/routers/target/listTargets.ts (+1 -0)
📝 server/routers/target/updateTarget.ts (+3 -1)
📝 src/app/[orgId]/settings/resources/[niceId]/proxy/page.tsx (+8 -3)
📝 src/app/[orgId]/settings/resources/create/page.tsx (+9 -3)
📝 src/components/HealthCheckDialog.tsx (+36 -2)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

While an SNI proxy already exists for configured targets themselves, this is not the case for sending periodic requests to targets' healthcheck endpoints.

This PR adds a field to the target healthcheck settings to specify an explicit SNI header for target healthcheck requests.

Screenshot 2025-12-03 at 23 27 49

Merging this PR requires https://github.com/fosrl/newt/pull/185 to be merged alongside it; as such, I'm not sure how the process goes for coordinating new behavior between Pangolin and Newt, but I believe that older versions of Newt would simply not support this field and silently ignore it since it won't get parsed out of the JSON response.

How to test?

Fill in the SNI field for a given target healthcheck and make sure that the downstream provider receives/proxies the client hello correctly as specified by the configured target healthcheck settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/1971 **Author:** [@water-sucks](https://github.com/water-sucks) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `add-tls-server-name-to-health-check-fields` --- ### 📝 Commits (2) - [`f33be14`](https://github.com/fosrl/pangolin/commit/f33be1434b689c9125746d1ad7de133a3b900afa) feat(schema): add TLS server name column to target healthcheck tables - [`ca9273c`](https://github.com/fosrl/pangolin/commit/ca9273c9eaded167d52f3c8f70bd968a6b015842) feat(healthcheck): add SNI input field to target healthcheck config ### 📊 Changes **11 files changed** (+72 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `messages/en-US.json` (+2 -0) 📝 `server/db/pg/schema/schema.ts` (+2 -1) 📝 `server/db/sqlite/schema/schema.ts` (+2 -1) 📝 `server/routers/newt/handleNewtRegisterMessage.ts` (+4 -2) 📝 `server/routers/newt/targets.ts` (+2 -1) 📝 `server/routers/target/createTarget.ts` (+3 -1) 📝 `server/routers/target/listTargets.ts` (+1 -0) 📝 `server/routers/target/updateTarget.ts` (+3 -1) 📝 `src/app/[orgId]/settings/resources/[niceId]/proxy/page.tsx` (+8 -3) 📝 `src/app/[orgId]/settings/resources/create/page.tsx` (+9 -3) 📝 `src/components/HealthCheckDialog.tsx` (+36 -2) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description While an SNI proxy already exists for configured targets themselves, this is not the case for sending periodic requests to targets' healthcheck endpoints. This PR adds a field to the target healthcheck settings to specify an explicit SNI header for target healthcheck requests. <img width="642" height="870" alt="Screenshot 2025-12-03 at 23 27 49" src="https://github.com/user-attachments/assets/258777c9-3769-47c8-bb16-12a15482c13f" /> Merging this PR requires https://github.com/fosrl/newt/pull/185 to be merged alongside it; as such, I'm not sure how the process goes for coordinating new behavior between Pangolin and Newt, but I believe that older versions of Newt would simply not support this field and silently ignore it since it won't get parsed out of the JSON response. ## How to test? Fill in the SNI field for a given target healthcheck and make sure that the downstream provider receives/proxies the client hello correctly as specified by the configured target healthcheck settings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 09:03:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?