github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-11 08:29:13 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[GH-ISSUE #2605] [gerbil]: Never online sites default to listenPort 0 #4140

New Issue
Closed
opened 2026-04-20 08:36:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 08:36:21 -05:00
Owner
Copy Link

Originally created by @LaurenceJJones on GitHub (Mar 5, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2605

Originally assigned to: @oschwartz10612 on GitHub.

Sites push which port and address they are listening on to Pangolin, if the site never comes online the listenPort is not configured within the database so:

483d54a9f0/server/lib/rebuildClientAssociations.ts (L580-L583)

will default the or condition to 0 which then triggers a gerbil error since nothing can bind to port 0 gerbil correctly expects a listenPort > 0.

ERROR: 2026/03/05 11:10:51 Destination port must be a positive integer for destination 4
ERROR: 2026/03/05 11:10:52 Destination port must be a positive integer for destination 4

User deleted the never online site from discussion below and it fixed the intermediate problem for them but we need to ensure that either we filter the status of the site before mapping the destinations or we simply do not define a or condition of 0.

or if we do allow an or condition of 0 then gerbil can smartly ignore these entries.

Discussed in https://github.com/orgs/fosrl/discussions/2604

Originally created by @LaurenceJJones on GitHub (Mar 5, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2605 Originally assigned to: @oschwartz10612 on GitHub. Sites push which port and address they are listening on to Pangolin, if the site never comes online the `listenPort` is not configured within the database so: https://github.com/fosrl/pangolin/blob/483d54a9f04572a13cbee4e49ac7006823a1c949/server/lib/rebuildClientAssociations.ts#L580-L583 will default the `or` condition to `0` which then triggers a gerbil error since nothing can bind to port `0` gerbil correctly expects a listenPort `> 0`. ``` ERROR: 2026/03/05 11:10:51 Destination port must be a positive integer for destination 4 ERROR: 2026/03/05 11:10:52 Destination port must be a positive integer for destination 4 ``` User deleted the never online site from discussion below and it fixed the intermediate problem for them but we need to ensure that either we filter the status of the site before mapping the destinations or we simply do not define a `or` condition of `0`. or if we do allow an or condition of `0` then gerbil can smartly ignore these entries. Discussed in https://github.com/orgs/fosrl/discussions/2604
GiteaMirror added the needs investigating label 2026-04-20 08:36:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label needs investigating
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?