github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-15 21:31:24 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[GH-ISSUE #2563] Create Share Link - Only the first 20 resources are available #4132

New Issue
Closed
opened 2026-04-20 08:35:42 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-20 08:35:42 -05:00
Owner
Copy Link

Originally created by @aweb-01 on GitHub (Feb 28, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2563

Originally assigned to: @miloschwartz on GitHub.

Describe the Bug

When I go to create a Share Link, in the "Resource"/"Select Resource" dropdown, only the first 20 resources (as shown on my "Network --> resources --> public" page are available. None of the resources on the 2nd page are available, and if I search for them I get "No resources found".

Environment

  • OS Type & Version: Ubuntu 24.04 (running everything in an up-to-date docker)
  • Pangolin Version: 1.16.1 (enterprise version)
  • Gerbil Version: 1.2.2
  • Traefik Version: 3.6.7
  • Newt Version: 1.6.0
  • Olm Version: (if applicable)

To Reproduce

When I go to create a Share Link, in the "Resource"/"Select Resource" dropdown, only the first 20 resources (as shown on my "Network --> resources --> public" page are available. None of the resources on the 2nd page are available, and if I search for them I get "No resources found".

Expected Behavior

all resources appear when searched

Originally created by @aweb-01 on GitHub (Feb 28, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2563 Originally assigned to: @miloschwartz on GitHub. ### Describe the Bug When I go to create a Share Link, in the "Resource"/"Select Resource" dropdown, only the first 20 resources (as shown on my "Network --> resources --> public" page are available. None of the resources on the 2nd page are available, and if I search for them I get "No resources found". ### Environment - OS Type & Version: Ubuntu 24.04 (running everything in an up-to-date docker) - Pangolin Version: 1.16.1 (enterprise version) - Gerbil Version: 1.2.2 - Traefik Version: 3.6.7 - Newt Version: 1.6.0 - Olm Version: (if applicable) ### To Reproduce When I go to create a Share Link, in the "Resource"/"Select Resource" dropdown, only the first 20 resources (as shown on my "Network --> resources --> public" page are available. None of the resources on the 2nd page are available, and if I search for them I get "No resources found". ### Expected Behavior all resources appear when searched
GiteaMirror added the bug label 2026-04-20 08:35:42 -05:00
GiteaMirror commented 2026-04-20 08:35:43 -05:00
Author
Owner
Copy Link

@LaurenceJJones commented on GitHub (Feb 28, 2026):

Issue happens because sharelink form only sends a default request to organization resources, the default pageSize is 20 if query parameter is not provided

72bf6f3c41/server/routers/resource/listResources.ts (L42-L53)

Since the dropdown is limited in functionality we should consider:

  • Allow a query parameter of pageSize=0 to get all resources?
    investigated will work but causes a scalable issue
  • Expose a search endpoint EG: /api/v1/org/{org}/resources/search to search all entries instead of client side filtering
    investigated original endpoint already has a query parameter we just need to send this from the search box inside the dropdown.
  • Listen to on scroll events in the dropdown and automatically expand pagination and resources as users scrolls the dropdown.
    needs more investigation
<!-- gh-comment-id:3977192868 --> @LaurenceJJones commented on GitHub (Feb 28, 2026): Issue happens because sharelink form only sends a default request to organization resources, the default pageSize is 20 if query parameter is not provided https://github.com/fosrl/pangolin/blob/72bf6f3c414a12a16c184a19f50ad08ed78f239f/server/routers/resource/listResources.ts#L42-L53 Since the dropdown is limited in functionality we should consider: - Allow a query parameter of `pageSize=0` to get all resources? _investigated_ will work but causes a scalable issue - Expose a search endpoint EG: `/api/v1/org/{org}/resources/search` to search all entries instead of client side filtering _investigated_ original endpoint already has a query parameter we just need to send this from the search box inside the dropdown. - Listen to on scroll events in the dropdown and automatically expand pagination and resources as users scrolls the dropdown. _needs more investigation_
GiteaMirror commented 2026-04-20 08:35:43 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Feb 28, 2026):

Ahh yep this is a mistake due to the new pagination in 1.16. Will fix and do a new patch.

<!-- gh-comment-id:3977598754 --> @oschwartz10612 commented on GitHub (Feb 28, 2026): Ahh yep this is a mistake due to the new pagination in 1.16. Will fix and do a new patch.
GiteaMirror commented 2026-04-20 08:35:43 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Feb 28, 2026):

Fixed in 1.16.2 though we will need to fix it properly in the future.

<!-- gh-comment-id:3977759839 --> @oschwartz10612 commented on GitHub (Feb 28, 2026): Fixed in 1.16.2 though we will need to fix it properly in the future.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?