github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-07 13:19:07 -05:00
Code Issues 564 Packages Projects Releases 72 Wiki Activity

[GH-ISSUE #2325] Too Big Error Updating Logo Url #4080

New Issue
Closed
opened 2026-04-20 08:31:00 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-04-20 08:31:00 -05:00
Owner
Copy Link

Originally created by @jiriteach on GitHub (Jan 25, 2026).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2325

Originally assigned to: @miloschwartz on GitHub.

Describe the Bug

Thanks for fixing the previous bug setting a url for the logo.

The previous url I was using worked. This url structure does not.

Change it and its throwing an error using a url structure like this -
URL - https://subdomain.domainname.com/images/Microsoft1.png - example. This is an active url - changed the values since I didnt want to post my actual url but provides a view of the structure which isn't anything complicated.

Error -

Too big: expected string to have <=0 characters

Environment

  • Pangolin Version: 1.15.1
  • Traefik Version: 3.6.7

To Reproduce

Enter logo url in the form of - URL - https://subdomain.domainname.com/images/Microsoft1.png - example. This url wont work since I didnt want to post my actual url.

Expected Behavior

For the logo url to be set.

Originally created by @jiriteach on GitHub (Jan 25, 2026). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2325 Originally assigned to: @miloschwartz on GitHub. ### Describe the Bug Thanks for fixing the previous bug setting a url for the logo. The previous url I was using worked. This url structure does not. Change it and its throwing an error using a url structure like this - URL - https://subdomain.domainname.com/images/Microsoft1.png - example. This is an active url - changed the values since I didnt want to post my actual url but provides a view of the structure which isn't anything complicated. Error - `Too big: expected string to have <=0 characters` ### Environment - Pangolin Version: 1.15.1 - Traefik Version: 3.6.7 ### To Reproduce Enter logo url in the form of - URL - https://subdomain.domainname.com/images/Microsoft1.png - example. This url wont work since I didnt want to post my actual url. ### Expected Behavior For the logo url to be set.
GiteaMirror added the bug label 2026-04-20 08:31:00 -05:00
GiteaMirror commented 2026-04-20 08:31:02 -05:00
Author
Owner
Copy Link

@jiriteach commented on GitHub (Jan 25, 2026):

Image
<!-- gh-comment-id:3796136675 --> @jiriteach commented on GitHub (Jan 25, 2026): <img width="617" height="118" alt="Image" src="https://github.com/user-attachments/assets/2598fe0b-7c14-4999-bbed-61b43a8cfaa4" />
GiteaMirror commented 2026-04-20 08:31:04 -05:00
Author
Owner
Copy Link

@JustMePawel commented on GitHub (Jan 26, 2026):

I do have the same issue..

<!-- gh-comment-id:3801614299 --> @JustMePawel commented on GitHub (Jan 26, 2026): I do have the same issue..
GiteaMirror commented 2026-04-20 08:31:04 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Jan 26, 2026):

We are working on a fix for the next patch. Make sure the url you enter
is a valid URL to a hosted image where the content type is an image.

<!-- gh-comment-id:3801927685 --> @oschwartz10612 commented on GitHub (Jan 26, 2026): We are working on a fix for the next patch. Make sure the url you enter is a valid URL to a hosted image where the content type is an image.
GiteaMirror commented 2026-04-20 08:31:07 -05:00
Author
Owner
Copy Link

@jiriteach commented on GitHub (Jan 27, 2026):

We are working on a fix for the next patch. Make sure the url you enter
is a valid URL to a hosted image where the content type is an image.

Thanks. In my case - its just an image hosted on Cloudlare r2 so s3 storage with publicly enabled access.

<!-- gh-comment-id:3802473234 --> @jiriteach commented on GitHub (Jan 27, 2026): > We are working on a fix for the next patch. Make sure the url you enter > is a valid URL to a hosted image where the content type is an image. Thanks. In my case - its just an image hosted on Cloudlare r2 so s3 storage with publicly enabled access.
GiteaMirror commented 2026-04-20 08:31:07 -05:00
Author
Owner
Copy Link

@gyoge0 commented on GitHub (Feb 1, 2026):

Relevant snippet

I think the two things going on here are:

  1. Cloudflare/S3 isn't properly setting the Content-Type header for your image
  2. Zod fails the url validation, falls back to the empty string case, fails the empty string case, and then displays the empty string error

I think the misleading error could be fixed by doing .superRefine and then explicitly setting the fallback order instead of dealing with Zod's default fallback order here:

logoUrl: z.string().superRefine(async (val, ctx) => {
    // empty string case from before
    if (val.length === 0) {
        return;
    }
    
    // check for url
    const urlResult = z.string().url().safeParse(val);
    if (!urlResult.success) {
        ctx.addIssue({
            code: z.ZodIssueCode.custom,
            message: "Must be a valid URL"
        });
        return;
    }
    
    // validate image
    try {
        ...
        if (failed) {
            ctx.addIssue({
                code: z.ZodIssueCode.custom,
                message: "Invalid logo URL, must be served as an image"
            });
        } else {
            return;
        }
    } catch (error) {
        ctx.addIssue({
            code: z.ZodIssueCode.custom,
            message: "Failed to retrieve image"
        });
    }
})

Would also help specify "valid image URL" means it's served back with a Content-Type header.

<!-- gh-comment-id:3832304765 --> @gyoge0 commented on GitHub (Feb 1, 2026): [Relevant snippet](https://github.com/fosrl/pangolin/blob/b0566d3c6fc0e2a993c8606acc128a68c4e27247/src/components/AuthPageBrandingForm.tsx#L45-L65) I think the two things going on here are: 1. Cloudflare/S3 isn't properly setting the `Content-Type` header for your image 2. Zod fails the url validation, falls back to the empty string case, fails the empty string case, and then displays the empty string error I think the misleading error could be fixed by doing `.superRefine` and then explicitly setting the fallback order instead of dealing with Zod's default fallback order here: ```ts logoUrl: z.string().superRefine(async (val, ctx) => { // empty string case from before if (val.length === 0) { return; } // check for url const urlResult = z.string().url().safeParse(val); if (!urlResult.success) { ctx.addIssue({ code: z.ZodIssueCode.custom, message: "Must be a valid URL" }); return; } // validate image try { ... if (failed) { ctx.addIssue({ code: z.ZodIssueCode.custom, message: "Invalid logo URL, must be served as an image" }); } else { return; } } catch (error) { ctx.addIssue({ code: z.ZodIssueCode.custom, message: "Failed to retrieve image" }); } }) ``` Would also help specify "valid image URL" means it's served back with a `Content-Type` header.
GiteaMirror commented 2026-04-20 08:31:08 -05:00
Author
Owner
Copy Link

@bobbleheadhobo commented on GitHub (Feb 5, 2026):

I am having the same issue. I have my logo hosted on Imgur, and I get the same error. Although I think something else is going on, like gyoge0 mentioned, because if I paste in the image address of the logo from the pangolin website, it works just fine. Any suggestions on where I should host my logo to get it to work?

<!-- gh-comment-id:3851274344 --> @bobbleheadhobo commented on GitHub (Feb 5, 2026): I am having the same issue. I have my logo hosted on Imgur, and I get the same error. Although I think something else is going on, like gyoge0 mentioned, because if I paste in the image address of the logo from the pangolin website, it works just fine. Any suggestions on where I should host my logo to get it to work?
GiteaMirror commented 2026-04-20 08:31:09 -05:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Feb 25, 2026):

I think this was resolved in 1.15.3. Please reopen if this was not the case.

<!-- gh-comment-id:3961179554 --> @oschwartz10612 commented on GitHub (Feb 25, 2026): I think this was resolved in 1.15.3. Please reopen if this was not the case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#4080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?