github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 06:08:33 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[GH-ISSUE #2125] public-resources and private-resources dont trigger blueprint updates #38870

New Issue
Closed
opened 2026-06-22 02:25:34 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-06-22 02:25:34 -05:00
Owner
Copy Link

Originally created by @angelrwu on GitHub (Dec 19, 2025).
Original GitHub issue: https://github.com/fosrl/pangolin/issues/2125

Describe the Bug

If you make a blueprint that uses public-resources instead of proxy-resources or private-resources instead of client-resources. The pangolin blueprint updater doesn't trigger and will output that an empty list of items was successfully updated "[]"

I believe the bug is related to this section https://github.com/fosrl/pangolin/blob/main/server/lib/blueprints/applyNewtDockerBlueprint.ts#L37-L40 or this https://github.com/fosrl/pangolin/blob/main/server/lib/blueprints/parseDockerContainers.ts#L54-L61
, but I'm unsure.

Environment

  • OS Type & Version: (e.g., Ubuntu 22.04)
  • Pangolin Version: 1.13.1
  • Gerbil Version: 1.2.1
  • Traefik Version: 3.6.1
  • Newt Version: 1.5.2
  • Olm Version: (if applicable)

To Reproduce

Insert a minimal blueprint with public-resources key or private-resources to get the bad case, and to get the happy path replace those for client and proxy.

Set the logging to debug to see the console output for the newt blueprint message and the pangolin blueprint update message

examples:

bad output when public and private resource are the key in blueprint

Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.812Z [debug]: Received blueprint: {"public-resources":{"testss-resource":{"full-domain":"testss.example.com","name":"tests-name","protocol":"http"}}}
Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.813Z [debug]: Successfully updated proxy resources for org example: []
Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.814Z [debug]: Successfully updated client resources for org example: []

good output when proxy and client resource are the key in blueprint

Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.292Z [debug]: Received blueprint: {"proxy-resources":{"tests-resource":{"full-domain":"tests.example.com","name":"tests-name","protocol":"http"}}}
Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.315Z [debug]: Created resource 4
Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.316Z [debug]: Successfully updated proxy resources for org example: [{"proxyResource":{"resourceId":4,"orgId":"example","niceId":"tests-resource","name":"tests-name","subdomain":null,"fullDomain":"tests.example.com","domainId":"domain1","ssl":true,"blockAccess":false,"sso":false,"http":true,"protocol":"tcp","proxyPort":null,"emailWhitelistEnabled":false,"applyRules":false,"enabled":true,"stickySession":false,"tlsServerName":null,"setHostHeader":null,"enableProxy":true,"skipToIdpId":null,"headers":null},"targetsToUpdate":[]}]
Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.317Z [debug]: Successfully updated client resources for org example: **[]**

Expected Behavior

Public and private resources key should trigger Pangolin to do resource updates or additions.
Alternatively the docs should be updated not to use public and private and use proxy and client, which would match the UI.

Originally created by @angelrwu on GitHub (Dec 19, 2025). Original GitHub issue: https://github.com/fosrl/pangolin/issues/2125 ### Describe the Bug If you make a blueprint that uses `public-resources` instead of `proxy-resources` or `private-resources` instead of `client-resources`. The pangolin blueprint updater doesn't trigger and will output that an empty list of items was successfully updated "[]" I believe the bug is related to this section https://github.com/fosrl/pangolin/blob/main/server/lib/blueprints/applyNewtDockerBlueprint.ts#L37-L40 or this https://github.com/fosrl/pangolin/blob/main/server/lib/blueprints/parseDockerContainers.ts#L54-L61 , but I'm unsure. ### Environment - OS Type & Version: (e.g., Ubuntu 22.04) - Pangolin Version: 1.13.1 - Gerbil Version: 1.2.1 - Traefik Version: 3.6.1 - Newt Version: 1.5.2 - Olm Version: (if applicable) ### To Reproduce Insert a minimal blueprint with public-resources key or private-resources to get the bad case, and to get the happy path replace those for client and proxy. Set the logging to debug to see the console output for the newt blueprint message and the pangolin blueprint update message examples: bad output when public and private resource are the key in blueprint ``` Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.812Z [debug]: Received blueprint: {"public-resources":{"testss-resource":{"full-domain":"testss.example.com","name":"tests-name","protocol":"http"}}} Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.813Z [debug]: Successfully updated proxy resources for org example: [] Dec 19 04:27:19 <hostname> pangolin[3772]: 2025-12-19T04:27:19.814Z [debug]: Successfully updated client resources for org example: [] ``` good output when proxy and client resource are the key in blueprint ``` Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.292Z [debug]: Received blueprint: {"proxy-resources":{"tests-resource":{"full-domain":"tests.example.com","name":"tests-name","protocol":"http"}}} Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.315Z [debug]: Created resource 4 Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.316Z [debug]: Successfully updated proxy resources for org example: [{"proxyResource":{"resourceId":4,"orgId":"example","niceId":"tests-resource","name":"tests-name","subdomain":null,"fullDomain":"tests.example.com","domainId":"domain1","ssl":true,"blockAccess":false,"sso":false,"http":true,"protocol":"tcp","proxyPort":null,"emailWhitelistEnabled":false,"applyRules":false,"enabled":true,"stickySession":false,"tlsServerName":null,"setHostHeader":null,"enableProxy":true,"skipToIdpId":null,"headers":null},"targetsToUpdate":[]}] Dec 19 04:26:25 <hostname> pangolin[3772]: 2025-12-19T04:26:25.317Z [debug]: Successfully updated client resources for org example: **[]** ``` ### Expected Behavior Public and private resources key should trigger Pangolin to do resource updates or additions. Alternatively the docs should be updated not to use public and private and use proxy and client, which would match the UI.
GiteaMirror commented 2026-06-22 02:25:36 -05:00
Author
Owner
Copy Link

@djcrafts commented on GitHub (Dec 21, 2025):

@angelrwu Hey! I've opened PR #2132 that should fix this issue.

The problem was that the Docker label parser and early-exit check only looked for proxy-resources and client-resources, ignoring the public-resources and private-resources aliases. The fix extends both to recognize all four resource types, and the existing ConfigSchema transformation handles merging them correctly.

Changes are minimal and backward compatible - existing labels will continue to work as before.

<!-- gh-comment-id:3678704854 --> @djcrafts commented on GitHub (Dec 21, 2025): @angelrwu Hey! I've opened PR #2132 that should fix this issue. The problem was that the Docker label parser and early-exit check only looked for [proxy-resources](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) and [client-resources](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html), ignoring the [public-resources](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) and [private-resources](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) aliases. The fix extends both to recognize all four resource types, and the existing ConfigSchema transformation handles merging them correctly. Changes are minimal and backward compatible - existing labels will continue to work as before.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#38870
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?