github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 14:47:04 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #3302] Fix inline policy fields in resource update response #36939

New Issue
Open
opened 2026-06-18 22:11:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-18 22:11:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/3302
Author: @RitwijParmar
Created: 6/17/2026
Status: 🔄 Open

Base: main ← Head: codex/resource-update-inline-policy-response

📝 Commits (1)

  • 95c3f74 Fix inline policy fields in resource update response

📊 Changes

4 files changed (+103 additions, -8 deletions)

View changed files

📝 server/routers/resource/getResource.ts (+2 -7)
➕ server/routers/resource/inlinePolicyFields.test.ts (+74 -0)
➕ server/routers/resource/inlinePolicyFields.ts (+19 -0)
📝 server/routers/resource/updateResource.ts (+8 -1)

📄 Description

Summary

  • fixes the POST /resource/{resourceId} response for inline policy resources so it returns the persisted policy values instead of null resource-row placeholders
  • shares the same inline policy overlay between GET and POST responses
  • preserves explicit false policy values instead of collapsing them to null
  • adds a focused regression test for true, false, and missing policy values

Fixes #3300

Checks

  • bunx prettier@3.8.3 --check server/routers/resource/updateResource.ts server/routers/resource/getResource.ts server/routers/resource/inlinePolicyFields.ts server/routers/resource/inlinePolicyFields.test.ts
  • bunx tsx@4.22.3 server/routers/resource/inlinePolicyFields.test.ts
  • git diff --check

I could not run npm run dev:check locally because this shell does not have npm/npx or node_modules available.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/3302 **Author:** [@RitwijParmar](https://github.com/RitwijParmar) **Created:** 6/17/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/resource-update-inline-policy-response` --- ### 📝 Commits (1) - [`95c3f74`](https://github.com/fosrl/pangolin/commit/95c3f74a339efaeaee7074bcf526ea037aee209b) Fix inline policy fields in resource update response ### 📊 Changes **4 files changed** (+103 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/resource/getResource.ts` (+2 -7) ➕ `server/routers/resource/inlinePolicyFields.test.ts` (+74 -0) ➕ `server/routers/resource/inlinePolicyFields.ts` (+19 -0) 📝 `server/routers/resource/updateResource.ts` (+8 -1) </details> ### 📄 Description ## Summary - fixes the POST /resource/{resourceId} response for inline policy resources so it returns the persisted policy values instead of null resource-row placeholders - shares the same inline policy overlay between GET and POST responses - preserves explicit false policy values instead of collapsing them to null - adds a focused regression test for true, false, and missing policy values Fixes #3300 ## Checks - bunx prettier@3.8.3 --check server/routers/resource/updateResource.ts server/routers/resource/getResource.ts server/routers/resource/inlinePolicyFields.ts server/routers/resource/inlinePolicyFields.test.ts - bunx tsx@4.22.3 server/routers/resource/inlinePolicyFields.test.ts - git diff --check I could not run npm run dev:check locally because this shell does not have npm/npx or node_modules available. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-18 22:11:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#36939
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?