github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 14:47:04 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #3119] [MERGED] Sort resource filter options in audit logs #36833

New Issue
Closed
opened 2026-06-18 22:06:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-18 22:06:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/3119
Author: @Adityakk9031
Created: 5/20/2026
Status: ✅ Merged
Merged: 5/28/2026
Merged by: @oschwartz10612

Base: main ← Head: #3086

📝 Commits (1)

  • 73e9e83 Sort resource filter options in audit logs

📊 Changes

3 files changed (+45 additions, -3 deletions)

View changed files

📝 server/private/routers/auditLogs/queryAccessAuditLog.ts (+15 -1)
📝 server/private/routers/auditLogs/queryConnectionAuditLog.ts (+15 -1)
📝 server/routers/auditLogs/queryRequestAuditLog.ts (+15 -1)

📄 Description

Description

Fixes #3086.

The resource filter dropdown in the HTTP request log was using the order returned by the audit-log filter attributes API. That API collected distinct resource IDs from log rows, fetched resource names, and returned the merged result without sorting. As a result, the dropdown order could appear ID-based, log-order-based, or otherwise inconsistent with the public resources view.

This change sorts resource filter options by resource name before returning them from the audit log APIs. It also applies the same ordering to access and connection log resource filters so similar dropdowns stay consistent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/3119 **Author:** [@Adityakk9031](https://github.com/Adityakk9031) **Created:** 5/20/2026 **Status:** ✅ Merged **Merged:** 5/28/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `#3086` --- ### 📝 Commits (1) - [`73e9e83`](https://github.com/fosrl/pangolin/commit/73e9e830c39d92e16a222e6e8570cc587c6bfc9e) Sort resource filter options in audit logs ### 📊 Changes **3 files changed** (+45 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/private/routers/auditLogs/queryAccessAuditLog.ts` (+15 -1) 📝 `server/private/routers/auditLogs/queryConnectionAuditLog.ts` (+15 -1) 📝 `server/routers/auditLogs/queryRequestAuditLog.ts` (+15 -1) </details> ### 📄 Description ## Description Fixes #3086. The resource filter dropdown in the HTTP request log was using the order returned by the audit-log filter attributes API. That API collected distinct resource IDs from log rows, fetched resource names, and returned the merged result without sorting. As a result, the dropdown order could appear ID-based, log-order-based, or otherwise inconsistent with the public resources view. This change sorts resource filter options by resource name before returning them from the audit log APIs. It also applies the same ordering to access and connection log resource filters so similar dropdowns stay consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-18 22:06:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#36833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?