0611ceb fix: make validators test failures exit non-zero
📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝server/lib/validators.test.ts (+1 -0)
📄 Description
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Tiny test cleanup: validators.test.ts logged failures but still exited 0.
That can make a broken test look green if someone wires it into a script later. Not ideal, lol. This makes it behave like the nearby test files and exit 1 on failure.
Related: I did not find a direct issue. #2807 is broader test-suite work, this is just the small papercut.
npm run set:oss
npm run set:sqlite
npx tsx server/lib/validators.test.ts
npx tsc --noEmit
npx prettier --check server/lib/validators.test.ts
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/fosrl/pangolin/pull/3026
**Author:** [@immanuwell](https://github.com/immanuwell)
**Created:** 5/7/2026
**Status:** ✅ Merged
**Merged:** 5/29/2026
**Merged by:** [@oschwartz10612](https://github.com/oschwartz10612)
**Base:** `dev` ← **Head:** `fix-validator-test-exit`
---
### 📝 Commits (1)
- [`0611ceb`](https://github.com/fosrl/pangolin/commit/0611ceb5c3becfdb332918987193797617a24961) fix: make validators test failures exit non-zero
### 📊 Changes
**1 file changed** (+1 additions, -0 deletions)
<details>
<summary>View changed files</summary>
📝 `server/lib/validators.test.ts` (+1 -0)
</details>
### 📄 Description
## Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
## Description
Tiny test cleanup: `validators.test.ts` logged failures but still exited `0`.
That can make a broken test look green if someone wires it into a script later. Not ideal, lol. This makes it behave like the nearby test files and exit `1` on failure.
Related: I did not find a direct issue. #2807 is broader test-suite work, this is just the small papercut.
## How to test?
Repro the bug shape:
```bash
node -e 'try { throw new Error("simulated assertion failure") } catch (error) { console.error("Test failed:", error.message) }'
```
It prints a failure but exits `0`.
Fixed behavior:
```bash
node -e 'try { throw new Error("simulated assertion failure") } catch (error) { console.error("Test failed:", error.message); process.exit(1) }'
```
It exits `1`, as expected.
Checked locally:
```bash
npm run set:oss
npm run set:sqlite
npx tsx server/lib/validators.test.ts
npx tsc --noEmit
npx prettier --check server/lib/validators.test.ts
```
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/fosrl/pangolin/pull/3026
Author: @immanuwell
Created: 5/7/2026
Status: ✅ Merged
Merged: 5/29/2026
Merged by: @oschwartz10612
Base:
dev← Head:fix-validator-test-exit📝 Commits (1)
0611cebfix: make validators test failures exit non-zero📊 Changes
1 file changed (+1 additions, -0 deletions)
View changed files
📝
server/lib/validators.test.ts(+1 -0)📄 Description
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
Tiny test cleanup:
validators.test.tslogged failures but still exited0.That can make a broken test look green if someone wires it into a script later. Not ideal, lol. This makes it behave like the nearby test files and exit
1on failure.Related: I did not find a direct issue. #2807 is broader test-suite work, this is just the small papercut.
How to test?
Repro the bug shape:
It prints a failure but exits
0.Fixed behavior:
It exits
1, as expected.Checked locally:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.