github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-07-16 06:08:33 -05:00
Code Issues 1.6k Packages Projects Releases 79 Wiki Activity

[PR #75] [MERGED] fix: add missing await when verifying pincode #33582

New Issue
Closed
opened 2026-06-17 03:12:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-17 03:12:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/75
Author: @mallendeo
Created: 1/18/2025
Status: ✅ Merged
Merged: 1/18/2025
Merged by: @miloschwartz

Base: main ← Head: patch-1

📝 Commits (1)

  • 6b141c3 fix: add missing await when verifying pincode

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/routers/resource/authWithPincode.ts (+1 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

When using a PIN, Pangolin grants access regardless of whether the PIN is correct or not.
This PR fixes that by waiting for the promise (validPincode ends up as a Promise and evaluates as a thruthy value wether the pin is correct or not).

Closes #74

How to test?

Create a PIN code for a resource, then try any password when accessing it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/75 **Author:** [@mallendeo](https://github.com/mallendeo) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`6b141c3`](https://github.com/fosrl/pangolin/commit/6b141c3ea01e259d488227d99194a8e8cf2ebbe0) fix: add missing `await` when verifying pincode ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/resource/authWithPincode.ts` (+1 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description When using a PIN, Pangolin grants access regardless of whether the PIN is correct or not. This PR fixes that by waiting for the promise (`validPincode` ends up as a `Promise` and evaluates as a thruthy value wether the pin is correct or not). Closes #74 ## How to test? Create a PIN code for a resource, then try any password when accessing it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-17 03:12:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#33582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?